[Libreoffice-commits] core.git: Branch 'libreoffice-6-4-1' - dbaccess/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Tue Feb 11 09:38:29 UTC 2020


 dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx |    2 --
 1 file changed, 2 deletions(-)

New commits:
commit 4f9491563ebbe0d21baefd7f614c535737982367
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sat Feb 8 20:06:23 2020 +0000
Commit:     Michael Stahl <michael.stahl at cib.de>
CommitDate: Tue Feb 11 10:37:59 2020 +0100

    Resolves: tdf#130484 controls become disabled on click final checkboxes
    
    they always triggered disabled the current state in the roadmap, but disabling
    a roadmap step now really disables the associated window in vcl.
    
    These two particular toggles don't actually affect the current roadmap state,
    so don't call state-modified when changing them.
    
    That doesn't change the ye-old weird case that the logical state of this final
    step is disabled, but don't let the wizard find that out when toggling
    radiobuttons that don't contribute to the roadmap state
    
    Change-Id: I5927d20ea461a294e76014892c90ad0b5f39fb6c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88281
    Tested-by: Jenkins
    Reviewed-by: Adolfo Jayme Barrientos <fitojb at ubuntu.com>
    (cherry picked from commit 1fbf3a70dbbbab2f810afae5f3e928a6d59c6325)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88297
    Reviewed-by: Xisco Faulí <xiscofauli at libreoffice.org>
    Reviewed-by: Michael Stahl <michael.stahl at cib.de>
    Tested-by: Michael Stahl <michael.stahl at cib.de>

diff --git a/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx b/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
index c806685f9f30..565cf61489b9 100644
--- a/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
+++ b/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
@@ -738,7 +738,6 @@ using namespace ::com::sun::star;
         , m_xFTFinalText(m_xBuilder->weld_label("finishText"))
     {
         m_xCBOpenAfterwards->connect_toggled(LINK(this, OFinalDBPageSetup, OnOpenSelected));
-        m_xCBStartTableWizard->connect_toggled(LINK(this,OGenericAdministrationPage,OnControlModifiedButtonClick));
         m_xRBRegisterDataSource->set_active(true);
         pController->SetFinalPage(this);
     }
@@ -796,7 +795,6 @@ using namespace ::com::sun::star;
     IMPL_LINK(OFinalDBPageSetup, OnOpenSelected, weld::ToggleButton&, rBox, void)
     {
         m_xCBStartTableWizard->set_sensitive(rBox.get_sensitive() && rBox.get_active());
-        callModifiedHdl();
     }
 }
 


More information about the Libreoffice-commits mailing list