[Libreoffice-commits] core.git: xmloff/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Wed Feb 12 14:35:21 UTC 2020


 xmloff/source/core/xmlictxt.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit b54e6db754f67c4a216c0f6d9b4a8d6315b1df16
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Wed Feb 12 14:06:25 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Wed Feb 12 15:34:49 2020 +0100

    crashtesting: remove assert in SvXMLImportContext::SvXMLImportContext
    
    which came from
        commit 813118bfbb453f812be9e1a30f84908b4e0bfb51
        Date:   Fri Dec 20 14:34:56 2019 +0200
        add checks to optional fields in SvXMLImportContext
    but it turns out various places abuse this field and pass stuff that is
    not a element name, including empty strings
    
    Change-Id: I33cfc7e44e0aafe0fdb084482a199d5cffde6a76
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88523
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/xmloff/source/core/xmlictxt.cxx b/xmloff/source/core/xmlictxt.cxx
index d3647f1faa44..c80158d02c96 100644
--- a/xmloff/source/core/xmlictxt.cxx
+++ b/xmloff/source/core/xmlictxt.cxx
@@ -34,7 +34,6 @@ SvXMLImportContext::SvXMLImportContext( SvXMLImport& rImp, sal_uInt16 nPrfx,
     , maLocalName(rLName)
     , mbPrefixAndLocalNameFilledIn(true)
 {
-    assert(!rLName.isEmpty());
 }
 
 SvXMLImportContext::SvXMLImportContext( SvXMLImport& rImp )


More information about the Libreoffice-commits mailing list