[Libreoffice-commits] core.git: basctl/source

[Caolán McNamara (via logerrit)]

 basctl/source/basicide/bastype2.cxx |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit c5d2c4cac83fb013052b490e212b79dc51605cd8
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Feb 12 12:29:30 2020 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Feb 12 17:05:39 2020 +0100

    we always want to expand/collapse on double click
    
    Change-Id: Idf5496b44f5e2d5782d99317029aa0e9cb99e8d0
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88527
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/basctl/source/basicide/bastype2.cxx b/basctl/source/basicide/bastype2.cxx
index 673a3daeabe9..378700bb5325 100644
--- a/basctl/source/basicide/bastype2.cxx
+++ b/basctl/source/basicide/bastype2.cxx
@@ -1501,6 +1501,11 @@ IMPL_LINK_NOARG(SbTreeListBox, OpenCurrentHdl, weld::TreeView&, bool)
     bool bValidIter = m_xControl->get_cursor(m_xIter.get());
     if (!bValidIter)
         return true;
+    if (!m_xControl->get_row_expanded(*m_xIter))
+        m_xControl->expand_row(*m_xIter);
+    else
+        m_xControl->collapse_row(*m_xIter);
+
     EntryDescriptor aDesc = GetEntryDescriptor(m_xIter.get());
     switch (aDesc.GetType())
     {
@@ -1518,15 +1523,10 @@ IMPL_LINK_NOARG(SbTreeListBox, OpenCurrentHdl, weld::TreeView&, bool)
                     SID_BASICIDE_SHOWSBX, SfxCallMode::SYNCHRON,
                     { &aSbxItem }
                 );
-                return true;
             }
             break;
 
         default:
-            if (!m_xControl->get_row_expanded(*m_xIter))
-                m_xControl->expand_row(*m_xIter);
-            else
-                m_xControl->collapse_row(*m_xIter);
             break;
     }
     return true;