[Libreoffice-commits] core.git: sw/source

[Dennis Francis (via logerrit)]

 sw/source/uibase/dochdl/swdtflvr.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 7155d0011ecde39c9ea27ef19d475686d80574ee
Author:     Dennis Francis <dennis.francis at collabora.com>
AuthorDate: Fri Feb 7 12:08:21 2020 +0530
Commit:     Andras Timar <andras.timar at collabora.com>
CommitDate: Wed Feb 12 21:27:58 2020 +0100

    Classify shape(s) selections as 'complex'...
    
    in isComplex() of XTransferable2 implementation SwTransferable.
    This method is used by online via doc_getSelectionType() to determine the
    type of selection. In writer this method used to classify shape objects as
    non-complex which translates to 'text' in online, so if a shape is selected
    in online, the js code there would treat it as text. This is problematic
    when you want to send the correct align uno commands based on selection type.
    So returning true in isComplex() for writer would correctly treat the shape
    selections as 'complex' in online Writer.
    
    Change-Id: I09fcd9e4fab48aa0d7e7d04c88bae9e1281a1b0c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88158
    Reviewed-by: Jan Holesovsky <kendy at collabora.com>
    Tested-by: Jan Holesovsky <kendy at collabora.com>
    (cherry picked from commit c7178a12e6e57e3d85cecd09e9c0373ececbb33f)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88495
    Tested-by: Jenkins
    Reviewed-by: Andras Timar <andras.timar at collabora.com>

diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx b/sw/source/uibase/dochdl/swdtflvr.cxx
index a0230ef3630a..6dbb5c50046b 100644
--- a/sw/source/uibase/dochdl/swdtflvr.cxx
+++ b/sw/source/uibase/dochdl/swdtflvr.cxx
@@ -455,6 +455,9 @@ sal_Bool SAL_CALL SwTransferable::isComplex()
         }
     }
 
+    if (m_pWrtShell->GetSelectionType() == SelectionType::DrawObject)
+        return true; // Complex
+
     // Simple
     return false;
 }