[Libreoffice-commits] core.git: sc/qa

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Fri Feb 14 11:54:26 UTC 2020


 sc/qa/extras/anchor.cxx           |   16 ++++++++++++++++
 sc/qa/unit/data/ods/tdf130556.ods |binary
 2 files changed, 16 insertions(+)

New commits:
commit 37d271570367686b07f696b2bf8afaee1b3da074
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Thu Feb 13 17:43:04 2020 +0100
Commit:     Xisco Faulí <xiscofauli at libreoffice.org>
CommitDate: Fri Feb 14 12:53:37 2020 +0100

    tdf#130556: Add unittest
    
    Change-Id: Iab632cd3afe6bb1c5f90a700a452c6c4dad14261
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88617
    Tested-by: Xisco Faulí <xiscofauli at libreoffice.org>
    Reviewed-by: Xisco Faulí <xiscofauli at libreoffice.org>

diff --git a/sc/qa/extras/anchor.cxx b/sc/qa/extras/anchor.cxx
index 55ac1b7cb77a..18ea4f9792fe 100644
--- a/sc/qa/extras/anchor.cxx
+++ b/sc/qa/extras/anchor.cxx
@@ -43,6 +43,7 @@ public:
     void testCopyColumnWithImages();
     void testCutWithImages();
     void testTdf129552();
+    void testTdf130556();
 
     CPPUNIT_TEST_SUITE(ScAnchorTest);
     CPPUNIT_TEST(testUndoAnchor);
@@ -51,6 +52,7 @@ public:
     CPPUNIT_TEST(testCopyColumnWithImages);
     CPPUNIT_TEST(testCutWithImages);
     CPPUNIT_TEST(testTdf129552);
+    CPPUNIT_TEST(testTdf130556);
     CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -384,6 +386,20 @@ void ScAnchorTest::testTdf129552()
     xComponent->dispose();
 }
 
+void ScAnchorTest::testTdf130556()
+{
+    OUString aFileURL;
+    createFileURL("tdf130556.ods", aFileURL);
+    uno::Reference<css::lang::XComponent> xComponent = loadFromDesktop(aFileURL);
+    CPPUNIT_ASSERT(xComponent.is());
+
+    // Without the accompanying fix in place, this test would have never returned due to an infinite
+    // invalidation loop, where ScGridWindow::Paint() invalidated itself.
+    Scheduler::ProcessEventsToIdle();
+
+    xComponent->dispose();
+}
+
 void ScAnchorTest::tearDown()
 {
     if (mxComponent.is())
diff --git a/sc/qa/unit/data/ods/tdf130556.ods b/sc/qa/unit/data/ods/tdf130556.ods
new file mode 100644
index 000000000000..c30a3e6f6180
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf130556.ods differ


More information about the Libreoffice-commits mailing list