[Libreoffice-commits] core.git: canvas/source

[Luboš Luňák (via logerrit)]

 canvas/source/vcl/spritecanvashelper.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 52c998be025563802a5056a15352e4608311be1d
Author:     Luboš Luňák <l.lunak at collabora.com>
AuthorDate: Fri Feb 14 14:01:19 2020 +0100
Commit:     Luboš Luňák <l.lunak at collabora.com>
CommitDate: Sun Feb 16 14:49:25 2020 +0100

    draw sprite bounds in vclcanvas only if explicitly asked for
    
    The #ifdef on debug level got reduced to normal debug builds
    as an Easy Hack in f0de4374fffe7f, but that means that the green
    debug lines are now drawn in all debug builds. The frame info
    debug text is at least obviously debug output, but "random" green
    lines look like drawing problems, so disable them, unless
    explicitly asked for.
    
    Change-Id: I56ebc799ca72565cabee35552c4bd2641e2393c7
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88713
    Tested-by: Jenkins
    Reviewed-by: Luboš Luňák <l.lunak at collabora.com>

diff --git a/canvas/source/vcl/spritecanvashelper.cxx b/canvas/source/vcl/spritecanvashelper.cxx
index 29c3295e4b59..8d58f4fcb359 100644
--- a/canvas/source/vcl/spritecanvashelper.cxx
+++ b/canvas/source/vcl/spritecanvashelper.cxx
@@ -126,7 +126,10 @@ namespace vclcanvas
     {
 #if OSL_DEBUG_LEVEL > 0
         // inverse defaults for verbose debug mode
-        mbShowSpriteBounds = mbShowFrameInfo = true;
+        mbShowFrameInfo = true;
+        // this looks like drawing errors, enable only if explicitly asked for
+        static bool enableShowSpriteBounds = getenv("CANVAS_SPRITE_BOUNDS") != nullptr;
+        mbShowSpriteBounds = enableShowSpriteBounds;
 #endif
     }