[Libreoffice-commits] core.git: testtools/source

Muhammet Kara (via logerrit) logerrit at kemper.freedesktop.org
Mon Feb 17 14:36:54 UTC 2020


 testtools/source/bridgetest/cli/cli_cpp_bridgetest.cxx |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit ce6434c44a9f820275908ff0ee4166427f481d6d
Author:     Muhammet Kara <muhammet.kara at collabora.com>
AuthorDate: Sun Feb 16 20:53:15 2020 +0300
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Feb 17 15:36:04 2020 +0100

    Remove never-executed else-block
    
    And the always-tru if-check
    
    Change-Id: I674d65506e1791fadab7d2871010528fd5dd94d0
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88816
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/testtools/source/bridgetest/cli/cli_cpp_bridgetest.cxx b/testtools/source/bridgetest/cli/cli_cpp_bridgetest.cxx
index abb082e3fd24..5deddf4005fb 100644
--- a/testtools/source/bridgetest/cli/cli_cpp_bridgetest.cxx
+++ b/testtools/source/bridgetest/cli/cli_cpp_bridgetest.cxx
@@ -112,15 +112,11 @@ public __gc class BridgeTest : public WeakBase, public XMain
             Any a2 = (Any) val2;
             ret = a1.Type == a2.Type && compareData(a1.Value, a2.Value);
         }
-        else if (t1->IsValueType)
+        else
         {
             //Any, enum, int, bool char, float, double etc.
             ret = val1->Equals(val2);
         }
-        else
-        {
-            Debug::Assert(false);
-        }
         return ret;
     }
 


More information about the Libreoffice-commits mailing list