[Libreoffice-commits] core.git: UnoControls/source

nienzu (via logerrit) logerrit at kemper.freedesktop.org
Wed Feb 19 11:32:04 UTC 2020


 UnoControls/source/controls/OConnectionPointHelper.cxx |   12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

New commits:
commit d8fe52d759ba033bd661893f12d17576d24276db
Author:     nienzu <tommy.wu at ossii.com.tw>
AuthorDate: Wed Feb 19 14:49:30 2020 +0800
Commit:     Michael Stahl <michael.stahl at cib.de>
CommitDate: Wed Feb 19 12:31:30 2020 +0100

    tdf#42982 add detail exception reason for UnoControls
    
    Change-Id: Ia62a0015d68fe819113322e27b93054d38d98aea
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88996
    Tested-by: Jenkins
    Reviewed-by: Michael Stahl <michael.stahl at cib.de>

diff --git a/UnoControls/source/controls/OConnectionPointHelper.cxx b/UnoControls/source/controls/OConnectionPointHelper.cxx
index a7f18ea2973b..f2c99421d3c6 100644
--- a/UnoControls/source/controls/OConnectionPointHelper.cxx
+++ b/UnoControls/source/controls/OConnectionPointHelper.cxx
@@ -105,8 +105,7 @@ Type SAL_CALL OConnectionPointHelper::getConnectionType()
     // Set default return value, if method failed.
     if ( !impl_LockContainer() )
     {
-        // Container not exist! It's a runtime error.
-        throw RuntimeException();
+        throw RuntimeException("Container does not exist!");
     }
 
     // If container reference valid, return right type of supported interfaces of THIS connectionpoint.
@@ -149,8 +148,7 @@ void SAL_CALL OConnectionPointHelper::advise( const Reference< XInterface >& xLi
     // Operation is permitted only, if reference to container is valid!
     if ( !impl_LockContainer() )
     {
-        // Container not exist! It's a runtime error.
-        throw RuntimeException();
+        throw RuntimeException("Container does not exist!");
     }
     // Forward it to OConnectionPointHelperContainer!
     m_pContainerImplementation->advise( m_aInterfaceType, xListener );
@@ -167,8 +165,7 @@ void SAL_CALL OConnectionPointHelper::unadvise( const Reference< XInterface >& x
     // Operation is permitted only, if reference to container is valid!
     if ( !impl_LockContainer() )
     {
-        // Container not exist! It's a runtime error.
-        throw RuntimeException();
+        throw RuntimeException("Container does not exist!");
 
     }
     // Forward it to OConnectionPointHelperContainer!
@@ -186,8 +183,7 @@ Sequence< Reference< XInterface > > SAL_CALL OConnectionPointHelper::getConnecti
     // Operation is permitted only, if reference to container is valid!
     if ( !impl_LockContainer() )
     {
-        // Container not exist! It's a runtime error.
-        throw RuntimeException();
+        throw RuntimeException("Container does not exist!");
     }
     // Set default return value, if method failed.
     Sequence< Reference< XInterface > > seqReturnConnections;


More information about the Libreoffice-commits mailing list