[Libreoffice-commits] core.git: connectivity/source

Faruk DemirbaÅŸ (via logerrit) logerrit at kemper.freedesktop.org
Thu Feb 20 10:01:14 UTC 2020


 connectivity/source/drivers/firebird/Table.cxx  |    2 +-
 connectivity/source/drivers/firebird/Tables.cxx |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit eee035a7c0d8923134d0e3a8520d13706ce9bf9f
Author:     Faruk Demirbaş <miskimit at gmail.com>
AuthorDate: Tue Jan 28 10:43:36 2020 +0300
Commit:     Michael Stahl <michael.stahl at cib.de>
CommitDate: Thu Feb 20 11:00:38 2020 +0100

    tdf#42982: Improve UNO API error reporting
    
    Change-Id: I36bf1809a296e2d559911f9132fedf84fcd1e249
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87577
    Tested-by: Michael Stahl <michael.stahl at cib.de>
    Reviewed-by: Michael Stahl <michael.stahl at cib.de>

diff --git a/connectivity/source/drivers/firebird/Table.cxx b/connectivity/source/drivers/firebird/Table.cxx
index df523235e2ac..0220a8458264 100644
--- a/connectivity/source/drivers/firebird/Table.cxx
+++ b/connectivity/source/drivers/firebird/Table.cxx
@@ -225,7 +225,7 @@ void SAL_CALL Table::alterColumnByName(const OUString& rColName,
 // ----- XRename --------------------------------------------------------------
 void SAL_CALL Table::rename(const OUString&)
 {
-    throw RuntimeException(); // Firebird doesn't support this.
+    throw RuntimeException("Table renaming not supported by Firebird.");
 }
 
 // ----- XInterface -----------------------------------------------------------
diff --git a/connectivity/source/drivers/firebird/Tables.cxx b/connectivity/source/drivers/firebird/Tables.cxx
index dc8255dbda61..7be79b5a2d4a 100644
--- a/connectivity/source/drivers/firebird/Tables.cxx
+++ b/connectivity/source/drivers/firebird/Tables.cxx
@@ -51,7 +51,7 @@ ObjectType Tables::createObject(const OUString& rName)
                                                                   uno::Sequence< OUString >());
 
     if (!xTables.is())
-        throw RuntimeException();
+        throw RuntimeException("Could not acquire table.");
 
     uno::Reference< XRow > xRow(xTables,UNO_QUERY_THROW);
 
@@ -66,7 +66,7 @@ ObjectType Tables::createObject(const OUString& rName)
                               xRow->getString(5))); // Description / Remarks / Comments
 
     if (xTables->next())
-        throw RuntimeException(); // Only one table should be returned
+        throw RuntimeException("Found more tables than expected.");
 
     return xRet;
 }


More information about the Libreoffice-commits mailing list