[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/inc/navipi.hxx    |    1 -
 sc/source/ui/navipi/navipi.cxx |   20 --------------------
 2 files changed, 21 deletions(-)

New commits:
commit 34585f09cf2b14eb3ef9c238e9b4050efb7028d9
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Feb 26 15:40:22 2020 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Feb 27 09:51:34 2020 +0100

    CheckDataArea is dead code
    
    nDataId is not a togglebutton so IsItemChecked is always false
    
    Change-Id: I6b75e36ee34f7234f1ffa11f38495e4dc1ad1eb6
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89558
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/inc/navipi.hxx b/sc/source/ui/inc/navipi.hxx
index 44d3c5ad1060..6db896fafe5d 100644
--- a/sc/source/ui/inc/navipi.hxx
+++ b/sc/source/ui/inc/navipi.hxx
@@ -248,7 +248,6 @@ private:
     const OUString& GetStrDragMode() const    { return aStrDragMode; }
     const OUString& GetStrDisplay() const     { return aStrDisplay; }
 
-    void    CheckDataArea   ();
     void    MarkDataArea    ();
     void    UnmarkDataArea  ();
     void    StartOfDataArea ();
diff --git a/sc/source/ui/navipi/navipi.cxx b/sc/source/ui/navipi/navipi.cxx
index 947554ee96d3..bae7c6b1df05 100644
--- a/sc/source/ui/navipi/navipi.cxx
+++ b/sc/source/ui/navipi/navipi.cxx
@@ -834,7 +834,6 @@ void ScNavigatorDlg::UpdateColumn( const SCCOL* pCol )
         nCurCol = pViewData->GetCurX() + 1;
 
     aEdCol->SetCol( nCurCol );
-    CheckDataArea();
 }
 
 void ScNavigatorDlg::UpdateRow( const SCROW* pRow )
@@ -845,7 +844,6 @@ void ScNavigatorDlg::UpdateRow( const SCROW* pRow )
         nCurRow = pViewData->GetCurY() + 1;
 
     aEdRow->SetRow( nCurRow );
-    CheckDataArea();
 }
 
 void ScNavigatorDlg::UpdateTable( const SCTAB* pTab )
@@ -854,8 +852,6 @@ void ScNavigatorDlg::UpdateTable( const SCTAB* pTab )
         nCurTab = *pTab;
     else if ( GetViewData() )
         nCurTab = pViewData->GetTabNo();
-
-    CheckDataArea();
 }
 
 void ScNavigatorDlg::UpdateAll()
@@ -1027,22 +1023,6 @@ void ScNavigatorDlg::UnmarkDataArea()
     }
 }
 
-void ScNavigatorDlg::CheckDataArea()
-{
-    if (aTbxCmd->IsItemChecked(nDataId) && pMarkArea)
-    {
-        if (   nCurTab   != pMarkArea->nTab
-            || nCurCol <  pMarkArea->nColStart+1
-            || nCurCol >  pMarkArea->nColEnd+1
-            || nCurRow <  pMarkArea->nRowStart+1
-            || nCurRow >  pMarkArea->nRowEnd+1 )
-        {
-            aTbxCmd->SetItemState(nDataId, TRISTATE_TRUE);
-            aTbxCmd->TriggerItem(nDataId);
-        }
-    }
-}
-
 void ScNavigatorDlg::StartOfDataArea()
 {
     //  pMarkArea evaluate ???