[Libreoffice-commits] core.git: sc/qa

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Thu Feb 27 11:01:34 UTC 2020


 sc/qa/unit/data/xlsx/tdf130959.xlsx    |binary
 sc/qa/unit/subsequent_filters-test.cxx |   10 ++++++++++
 2 files changed, 10 insertions(+)

New commits:
commit 5c6adee9f11c78d7a2731e015d270edeb5c5191e
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Thu Feb 27 10:06:38 2020 +0100
Commit:     Xisco Faulí <xiscofauli at libreoffice.org>
CommitDate: Thu Feb 27 12:01:00 2020 +0100

    tdf#130959: Add unittest
    
    Change-Id: Ib66a2a48b6e0d746fc54d2b1987a574c26ea1c1e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89619
    Tested-by: Jenkins
    Reviewed-by: Xisco Faulí <xiscofauli at libreoffice.org>

diff --git a/sc/qa/unit/data/xlsx/tdf130959.xlsx b/sc/qa/unit/data/xlsx/tdf130959.xlsx
new file mode 100644
index 000000000000..3f1b16c2c5a3
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf130959.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx
index 4038430dceee..ecc1a1003ee1 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -227,6 +227,7 @@ public:
     void testTdf100709XLSX();
     void testTdf97598XLSX();
     void testTdf110440XLSX();
+    void testTdf130959();
     void testTdf111974XLSM();
     void testTdf83672XLSX();
 
@@ -371,6 +372,7 @@ public:
     CPPUNIT_TEST(testTdf100709XLSX);
     CPPUNIT_TEST(testTdf97598XLSX);
     CPPUNIT_TEST(testTdf110440XLSX);
+    CPPUNIT_TEST(testTdf130959);
     CPPUNIT_TEST(testTdf111974XLSM);
     CPPUNIT_TEST(testTdf83672XLSX);
 
@@ -3540,6 +3542,14 @@ void ScFiltersTest::testTdf110440XLSX()
     xDocSh->DoClose();
 }
 
+void ScFiltersTest::testTdf130959()
+{
+    // Would crash without the fix on loading
+    ScDocShellRef xDocSh = loadDoc("tdf130959.", FORMAT_XLSX);
+    CPPUNIT_ASSERT_MESSAGE("Failed to open doc", xDocSh.is());
+    xDocSh->DoClose();
+}
+
 void ScFiltersTest::testTdf111974XLSM()
 {
     // Would crash without the fix on loading


More information about the Libreoffice-commits mailing list