[Libreoffice-commits] core.git: sd/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Fri Jan 3 18:29:05 UTC 2020


 sd/source/ui/func/futext.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 36c0dd46943f16e1c83f9322df616212f9dce864
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Jan 3 14:53:19 2020 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Jan 3 19:28:31 2020 +0100

    cid#1456606 Dereference after null check
    
    Change-Id: Ic1467982a7366db6266eaab3e08ca52f2785bac4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86181
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx
index 3523a5efef69..f26d25504722 100644
--- a/sd/source/ui/func/futext.cxx
+++ b/sd/source/ui/func/futext.cxx
@@ -195,7 +195,7 @@ void FuText::DoExecute( SfxRequest& )
         SdrViewEvent aVEvt;
         mpView->PickAnything(aMEvt, SdrMouseEventKind::BUTTONDOWN, aVEvt);
         mpView->MarkObj(aVEvt.pRootObj, pPV);
-        if (comphelper::LibreOfficeKit::isActive() && mpViewShell && mpViewShell->GetDocSh())
+        if (comphelper::LibreOfficeKit::isActive() && mpViewShell->GetDocSh())
             mpViewShell->GetDocSh()->SetModified();
 
         mxTextObj.reset( dynamic_cast< SdrTextObj* >( aVEvt.pObj ) );


More information about the Libreoffice-commits mailing list