[Libreoffice-commits] core.git: basic/source

Mike Kaganski (via logerrit) logerrit at kemper.freedesktop.org
Sat Jan 4 09:27:57 UTC 2020


 basic/source/sbx/sbxscan.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 6bdfcd317f87ab1948f56eb1231db1378c51c2f8
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sat Jan 4 09:41:22 2020 +0100
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sat Jan 4 10:27:23 2020 +0100

    VBA: don't SAL_WARN on value-to-number conversion error
    
    Error to convert a value to number is signalled to user normally as a
    standard Basic error; it's nothing a developer should worry about.
    
    Change-Id: Ia6ca316f374ffe392eb1a7b4ffac52fd53ba2fb1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86210
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/basic/source/sbx/sbxscan.cxx b/basic/source/sbx/sbxscan.cxx
index f555908b6b84..e15039243fea 100644
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@@ -258,7 +258,6 @@ ErrCode ImpScan( const OUString& rWSrc, double& nVal, SbxDataType& rType,
 #if HAVE_FEATURE_SCRIPTING
     else if ( SbiRuntime::isVBAEnabled() )
     {
-        SAL_WARN("basic", "Reporting error converting");
         return ERRCODE_BASIC_CONVERSION;
     }
 #endif


More information about the Libreoffice-commits mailing list