[Libreoffice-commits] core.git: cui/IwyuFilter_cui.yaml cui/source

Gabor Kelemen (via logerrit) logerrit at kemper.freedesktop.org
Mon Jan 6 09:41:08 UTC 2020 

 cui/IwyuFilter_cui.yaml                             |   17 +++++++++++++++++
 cui/source/customize/CustomNotebookbarGenerator.cxx |    1 -
 cui/source/customize/SvxMenuConfigPage.cxx          |    2 --
 cui/source/customize/SvxToolbarConfigPage.cxx       |    1 -
 cui/source/customize/acccfg.cxx                     |    1 -
 cui/source/customize/cfg.cxx                        |    1 -
 cui/source/dialogs/QrCodeGenDialog.cxx              |    4 ----
 cui/source/dialogs/about.cxx                        |    1 -
 cui/source/dialogs/screenshotannotationdlg.cxx      |    3 +--
 cui/source/dialogs/scriptdlg.cxx                    |    1 -
 cui/source/inc/autocdlg.hxx                         |    1 +
 cui/source/inc/backgrnd.hxx                         |    4 ----
 cui/source/options/optaboutconfig.cxx               |    1 -
 cui/source/options/optcolor.cxx                     |    2 --
 cui/source/options/optgdlg.cxx                      |    2 --
 cui/source/options/optinet2.cxx                     |    1 -
 cui/source/options/optpath.cxx                      |    2 --
 cui/source/tabpages/align.cxx                       |    2 --
 cui/source/tabpages/border.cxx                      |    1 -
 cui/source/tabpages/labdlg.cxx                      |    2 --
 cui/source/tabpages/numpages.cxx                    |    1 -
 cui/source/tabpages/page.cxx                        |    1 -
 cui/source/tabpages/swpossizetabpage.cxx            |    1 -
 cui/source/tabpages/tpline.cxx                      |    1 -
 cui/source/tabpages/tplnedef.cxx                    |    1 -
 cui/source/tabpages/tplneend.cxx                    |    1 -
 cui/source/tabpages/transfrm.cxx                    |    1 -
 cui/source/uno/services.cxx                         |    1 -
 28 files changed, 19 insertions(+), 39 deletions(-)

New commits:
commit ed1ece19d4983ea47b296086aaa0ea91fe11935d
Author:     Gabor Kelemen <kelemen.gabor2 at nisz.hu>
AuthorDate: Tue Dec 24 12:20:52 2019 +0100
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Mon Jan 6 10:40:37 2020 +0100

    tdf#42949 Fix IWYU warnings in cui/
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: I41ae36eb535cc64f4c4fa73333dbc8aa728865b7
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85791
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/cui/IwyuFilter_cui.yaml b/cui/IwyuFilter_cui.yaml
index 52c313d212ed..1eddb717899c 100644
--- a/cui/IwyuFilter_cui.yaml
+++ b/cui/IwyuFilter_cui.yaml
@@ -4,3 +4,20 @@ blacklist:
     cui/source/customize/macropg.cxx:
     # Needed for TypedWhichId macro
     - svl/macitem.hxx
+    cui/source/customize/CommandCategoryListBox.cxx:
+    # Actually used
+    - com/sun/star/script/browse/XBrowseNode.hpp
+    cui/source/customize/cfgutil.cxx:
+    # Actually used
+    - com/sun/star/script/browse/XBrowseNode.hpp
+    cui/source/dialogs/DiagramDialog.cxx:
+    # Needed for direct member access
+    - com/sun/star/beans/PropertyValue.hpp
+    cui/source/dialogs/SignSignatureLineDialog.cxx:
+    # Actually used
+    - com/sun/star/graphic/XGraphic.hpp
+    - com/sun/star/security/XCertificate.hpp
+    cui/source/dialogs/thesdlg.cxx:
+    # Actually used
+    - com/sun/star/linguistic2/XMeaning.hpp
+    - com/sun/star/linguistic2/XThesaurus.hpp
diff --git a/cui/source/customize/CustomNotebookbarGenerator.cxx b/cui/source/customize/CustomNotebookbarGenerator.cxx
index 374b1450ae97..89310849537a 100644
--- a/cui/source/customize/CustomNotebookbarGenerator.cxx
+++ b/cui/source/customize/CustomNotebookbarGenerator.cxx
@@ -19,7 +19,6 @@
 
 #include <comphelper/processfactory.hxx>
 #include <rtl/bootstrap.hxx>
-#include <rtl/ustrbuf.hxx>
 #include <config_folders.h>
 #include <CustomNotebookbarGenerator.hxx>
 #include <osl/file.hxx>
diff --git a/cui/source/customize/SvxMenuConfigPage.cxx b/cui/source/customize/SvxMenuConfigPage.cxx
index 7289b3506a7c..bb4ebbf51cae 100644
--- a/cui/source/customize/SvxMenuConfigPage.cxx
+++ b/cui/source/customize/SvxMenuConfigPage.cxx
@@ -20,11 +20,9 @@
 #include <sal/config.h>
 #include <sal/log.hxx>
 
-#include <vcl/commandinfoprovider.hxx>
 #include <vcl/weld.hxx>
 #include <vcl/svapp.hxx>
 
-#include <algorithm>
 #include <strings.hrc>
 #include <helpids.h>
 
diff --git a/cui/source/customize/SvxToolbarConfigPage.cxx b/cui/source/customize/SvxToolbarConfigPage.cxx
index b30302d52ed3..372840d91287 100644
--- a/cui/source/customize/SvxToolbarConfigPage.cxx
+++ b/cui/source/customize/SvxToolbarConfigPage.cxx
@@ -20,7 +20,6 @@
 #include <sal/config.h>
 #include <sal/log.hxx>
 
-#include <vcl/commandinfoprovider.hxx>
 #include <vcl/event.hxx>
 #include <vcl/weld.hxx>
 #include <vcl/svapp.hxx>
diff --git a/cui/source/customize/acccfg.cxx b/cui/source/customize/acccfg.cxx
index 24a601d0af99..cb1ed554d501 100644
--- a/cui/source/customize/acccfg.cxx
+++ b/cui/source/customize/acccfg.cxx
@@ -62,7 +62,6 @@
 #include <comphelper/processfactory.hxx>
 #include <svtools/acceleratorexecute.hxx>
 #include <vcl/svapp.hxx>
-#include <vcl/help.hxx>
 #include <comphelper/sequenceashashmap.hxx>
 // namespaces
 
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 6c98193e799b..2cdfc4c245ab 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -61,7 +61,6 @@
 #include <com/sun/star/embed/ElementModes.hpp>
 #include <com/sun/star/embed/FileSystemStorageFactory.hpp>
 #include <com/sun/star/frame/ModuleManager.hpp>
-#include <com/sun/star/frame/UnknownModuleException.hpp>
 #include <com/sun/star/frame/XFrames.hpp>
 #include <com/sun/star/frame/XLayoutManager.hpp>
 #include <com/sun/star/frame/FrameSearchFlag.hpp>
diff --git a/cui/source/dialogs/QrCodeGenDialog.cxx b/cui/source/dialogs/QrCodeGenDialog.cxx
index d936219f7209..7daaee9afa04 100644
--- a/cui/source/dialogs/QrCodeGenDialog.cxx
+++ b/cui/source/dialogs/QrCodeGenDialog.cxx
@@ -14,7 +14,6 @@
 #include <unotools/streamwrap.hxx>
 #include <utility>
 #include <vcl/weld.hxx>
-#include <sal/log.hxx>
 
 #if defined(SYSTEM_QRCODEGEN)
 #include <qrcodegen/QrCode.hpp>
@@ -34,15 +33,12 @@
 #include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
 #include <com/sun/star/sheet/XSpreadsheet.hpp>
-#include <com/sun/star/sheet/XSpreadsheetDocument.hpp>
 #include <com/sun/star/sheet/XSpreadsheetView.hpp>
 #include <com/sun/star/text/TextContentAnchorType.hpp>
 #include <com/sun/star/text/XTextContent.hpp>
-#include <com/sun/star/text/XTextDocument.hpp>
 #include <com/sun/star/text/XTextViewCursor.hpp>
 #include <com/sun/star/text/XTextViewCursorSupplier.hpp>
 #include <config_fuzzers.h>
-#include <com/sun/star/drawing/XDrawPagesSupplier.hpp>
 #include <com/sun/star/drawing/XDrawView.hpp>
 #include <com/sun/star/drawing/XDrawPage.hpp>
 
diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx
index 614c559e1039..625adf9f9a7c 100644
--- a/cui/source/dialogs/about.cxx
+++ b/cui/source/dialogs/about.cxx
@@ -26,7 +26,6 @@
 #include <vcl/settings.hxx>
 #include <vcl/stdtext.hxx>
 #include <vcl/svapp.hxx>
-#include <vcl/virdev.hxx>
 #include <vcl/weld.hxx>
 
 #include <unotools/configmgr.hxx>
diff --git a/cui/source/dialogs/screenshotannotationdlg.cxx b/cui/source/dialogs/screenshotannotationdlg.cxx
index 8dd164f7c9e9..dca914c1517c 100644
--- a/cui/source/dialogs/screenshotannotationdlg.cxx
+++ b/cui/source/dialogs/screenshotannotationdlg.cxx
@@ -23,10 +23,9 @@
 #include <dialmgr.hxx>
 
 #include <basegfx/range/b2irange.hxx>
-#include <cppuhelper/bootstrap.hxx>
-#include <com/sun/star/ui/dialogs/FilePicker.hpp>
 #include <com/sun/star/ui/dialogs/TemplateDescription.hpp>
 #include <com/sun/star/ui/dialogs/ExecutableDialogResults.hpp>
+#include <com/sun/star/ui/dialogs/XFilePicker3.hpp>
 
 #include <comphelper/random.hxx>
 #include <basegfx/polygon/b2dpolygontools.hxx>
diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index 12da15e0c2b6..80bab2715ca4 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -20,7 +20,6 @@
 #include <memory>
 #include <utility>
 
-#include <sal/log.hxx>
 #include <sfx2/objsh.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
diff --git a/cui/source/inc/autocdlg.hxx b/cui/source/inc/autocdlg.hxx
index 083f3824713c..896a481b711c 100644
--- a/cui/source/inc/autocdlg.hxx
+++ b/cui/source/inc/autocdlg.hxx
@@ -23,6 +23,7 @@
 #include <svx/langbox.hxx>
 #include <vcl/metric.hxx>
 
+#include <map>
 #include <set>
 
 class CharClass;
diff --git a/cui/source/inc/backgrnd.hxx b/cui/source/inc/backgrnd.hxx
index 1339e176a9c9..14d30703e745 100644
--- a/cui/source/inc/backgrnd.hxx
+++ b/cui/source/inc/backgrnd.hxx
@@ -19,10 +19,6 @@
 #ifndef INCLUDED_CUI_SOURCE_INC_BACKGRND_HXX
 #define INCLUDED_CUI_SOURCE_INC_BACKGRND_HXX
 
-#include <vcl/graph.hxx>
-#include <svx/SvxColorValueSet.hxx>
-#include <svx/dlgctrl.hxx>
-#include <editeng/brushitem.hxx>
 #include <memory>
 
 #include "cuitabarea.hxx"
diff --git a/cui/source/options/optaboutconfig.cxx b/cui/source/options/optaboutconfig.cxx
index a5adf7638c8d..728c3c68d258 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -24,7 +24,6 @@
 #include <vcl/event.hxx>
 #include <sal/log.hxx>
 #include <tools/diagnose_ex.h>
-#include <tools/debug.hxx>
 
 #include <memory>
 #include <vector>
diff --git a/cui/source/options/optcolor.cxx b/cui/source/options/optcolor.cxx
index 360c18e80d49..0f05784d5bae 100644
--- a/cui/source/options/optcolor.cxx
+++ b/cui/source/options/optcolor.cxx
@@ -21,14 +21,12 @@
 
 #include <bitset>
 
-#include <osl/diagnose.h>
 #include <tools/debug.hxx>
 #include <editeng/editids.hrc>
 #include <svtools/colorcfg.hxx>
 #include <svtools/extcolorcfg.hxx>
 #include <svx/colorbox.hxx>
 #include <unotools/moduleoptions.hxx>
-#include <vcl/settings.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
 #include <svx/svxdlg.hxx>
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index 5f5117e24971..f891f2c512ad 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -23,7 +23,6 @@
 #include <svl/currencytable.hxx>
 #include <svtools/langhelp.hxx>
 #include <unotools/lingucfg.hxx>
-#include <unotools/resmgr.hxx>
 #include <sfx2/bindings.hxx>
 #include <sfx2/viewfrm.hxx>
 #include <i18nlangtag/mslangid.hxx>
@@ -52,7 +51,6 @@
 #include <officecfg/Setup.hxx>
 #include <comphelper/configuration.hxx>
 #include <tools/diagnose_ex.h>
-#include <desktop/crashreport.hxx>
 
 #include <com/sun/star/configuration/theDefaultProvider.hpp>
 #include <com/sun/star/container/XNameAccess.hpp>
diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx
index 5e3c6a878ff4..a4acc0b96d9f 100644
--- a/cui/source/options/optinet2.cxx
+++ b/cui/source/options/optinet2.cxx
@@ -24,7 +24,6 @@
 #include <officecfg/Inet.hxx>
 #include <officecfg/Office/Common.hxx>
 #include <officecfg/Office/Security.hxx>
-#include <toolkit/helper/vclunohelper.hxx>
 #include <vcl/weld.hxx>
 #include <sfx2/filedlghelper.hxx>
 #include <vcl/svapp.hxx>
diff --git a/cui/source/options/optpath.cxx b/cui/source/options/optpath.cxx
index 7fd41fa1ee49..4d0bdd08bec1 100644
--- a/cui/source/options/optpath.cxx
+++ b/cui/source/options/optpath.cxx
@@ -30,7 +30,6 @@
 #include <dialmgr.hxx>
 #include <optpath.hxx>
 #include <strings.hrc>
-#include <comphelper/configuration.hxx>
 #include <comphelper/processfactory.hxx>
 #include <comphelper/string.hxx>
 #include <com/sun/star/uno/Exception.hpp>
@@ -41,7 +40,6 @@
 #include <com/sun/star/ui/dialogs/FilePicker.hpp>
 #include <com/sun/star/ui/dialogs/TemplateDescription.hpp>
 #include <com/sun/star/util/thePathSettings.hpp>
-#include <officecfg/Office/Common.hxx>
 #include <tools/diagnose_ex.h>
 #include <sal/log.hxx>
 
diff --git a/cui/source/tabpages/align.cxx b/cui/source/tabpages/align.cxx
index 6af362814cbd..33cce4de3795 100644
--- a/cui/source/tabpages/align.cxx
+++ b/cui/source/tabpages/align.cxx
@@ -31,8 +31,6 @@
 #include <editeng/justifyitem.hxx>
 #include <svl/cjkoptions.hxx>
 #include <svl/intitem.hxx>
-#include <vcl/settings.hxx>
-#include <vcl/event.hxx>
 #include <vcl/image.hxx>
 
 #define IID_BOTTOMLOCK 1
diff --git a/cui/source/tabpages/border.cxx b/cui/source/tabpages/border.cxx
index 84bdcd8f92c1..107b01f4663f 100644
--- a/cui/source/tabpages/border.cxx
+++ b/cui/source/tabpages/border.cxx
@@ -29,7 +29,6 @@
 #include <svx/dlgutil.hxx>
 #include <dialmgr.hxx>
 #include <sfx2/htmlmode.hxx>
-#include <vcl/event.hxx>
 #include <vcl/settings.hxx>
 #include <vcl/svapp.hxx>
 #include <svx/flagsdef.hxx>
diff --git a/cui/source/tabpages/labdlg.cxx b/cui/source/tabpages/labdlg.cxx
index 440734c130a2..cda75610365c 100644
--- a/cui/source/tabpages/labdlg.cxx
+++ b/cui/source/tabpages/labdlg.cxx
@@ -18,8 +18,6 @@
  */
 
 #include <swpossizetabpage.hxx>
-#include <vcl/event.hxx>
-#include <vcl/settings.hxx>
 #include <svtools/unitconv.hxx>
 
 #include <svx/svddef.hxx>
diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx
index 49ded0f6c562..9c10291bd1d3 100644
--- a/cui/source/tabpages/numpages.cxx
+++ b/cui/source/tabpages/numpages.cxx
@@ -58,7 +58,6 @@
 #include <sfx2/opengrf.hxx>
 
 #include <strings.hrc>
-#include <svl/aeitem.hxx>
 #include <svl/stritem.hxx>
 #include <svl/slstitm.hxx>
 #include <sfx2/filedlghelper.hxx>
diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index 11c533d56d2a..ccb159205308 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -48,7 +48,6 @@
 #include <svx/svxids.hrc>
 #include <svtools/optionsdrawinglayer.hxx>
 #include <svl/slstitm.hxx>
-#include <svl/aeitem.hxx>
 #include <svx/xdef.hxx>
 #include <svx/unobrushitemhelper.hxx>
 #include <svx/SvxNumOptionsTabPageHelper.hxx>
diff --git a/cui/source/tabpages/swpossizetabpage.cxx b/cui/source/tabpages/swpossizetabpage.cxx
index 24251a1800c1..9b144bf47919 100644
--- a/cui/source/tabpages/swpossizetabpage.cxx
+++ b/cui/source/tabpages/swpossizetabpage.cxx
@@ -22,7 +22,6 @@
 #include <swpossizetabpage.hxx>
 #include <svx/dlgutil.hxx>
 #include <svx/anchorid.hxx>
-#include <svl/aeitem.hxx>
 #include <svl/intitem.hxx>
 #include <svx/swframevalidation.hxx>
 #include <sfx2/htmlmode.hxx>
diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index beb9018d4361..c5a658f4fd71 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -60,7 +60,6 @@
 #include <svx/dialmgr.hxx>
 #include <svx/svxids.hrc>
 #include <svx/strings.hrc>
-#include <vcl/settings.hxx>
 #include <cuitabarea.hxx>
 #include <svtools/unitconv.hxx>
 
diff --git a/cui/source/tabpages/tplnedef.cxx b/cui/source/tabpages/tplnedef.cxx
index 7f62d3a716d0..8662c42985fb 100644
--- a/cui/source/tabpages/tplnedef.cxx
+++ b/cui/source/tabpages/tplnedef.cxx
@@ -18,7 +18,6 @@
  */
 
 #include <tools/urlobj.hxx>
-#include <vcl/settings.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
 #include <unotools/pathoptions.hxx>
diff --git a/cui/source/tabpages/tplneend.cxx b/cui/source/tabpages/tplneend.cxx
index 3119058f739f..d537b7ea1ac9 100644
--- a/cui/source/tabpages/tplneend.cxx
+++ b/cui/source/tabpages/tplneend.cxx
@@ -18,7 +18,6 @@
  */
 
 #include <tools/urlobj.hxx>
-#include <vcl/settings.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
 #include <unotools/pathoptions.hxx>
diff --git a/cui/source/tabpages/transfrm.cxx b/cui/source/tabpages/transfrm.cxx
index c67d69da6026..5dc45a108ff8 100644
--- a/cui/source/tabpages/transfrm.cxx
+++ b/cui/source/tabpages/transfrm.cxx
@@ -36,7 +36,6 @@
 #include <svx/dlgutil.hxx>
 #include <svx/anchorid.hxx>
 #include <svl/rectitem.hxx>
-#include <svl/aeitem.hxx>
 #include <swpossizetabpage.hxx>
 #include <vcl/canvastools.hxx>
 
diff --git a/cui/source/uno/services.cxx b/cui/source/uno/services.cxx
index 2b29158f9fb3..62c6bbaf47a1 100644
--- a/cui/source/uno/services.cxx
+++ b/cui/source/uno/services.cxx
@@ -17,7 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include <com/sun/star/registry/XRegistryKey.hpp>
 #include <sal/types.h>
 #include <cppuhelper/factory.hxx>
 #include <cppuhelper/implementationentry.hxx>

More information about the Libreoffice-commits mailing list