[Libreoffice-commits] core.git: Branch 'libreoffice-6-4' - cui/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Sat Jan 11 22:29:25 UTC 2020


 cui/source/tabpages/tabstpge.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dfb60d3b80ca8459505ab7e4599eb9406f1bfb3e
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Jan 10 21:13:04 2020 +0000
Commit:     Adolfo Jayme Barrientos <fitojb at ubuntu.com>
CommitDate: Sat Jan 11 23:28:57 2020 +0100

    Resolves: tdf#127417 delete-all tabs doesn't work
    
    since...
    
    commit 1e2682235cded9a7cd90e55f0bfc60a1285e9a46
    Date:   Thu Apr 18 19:25:06 2019 +0200
    
        WIP: Further preparations for deeper Item changes
    
    because since then aNewTabs is cloned, but on delete-all
    aNewTabs is reset to a SvxTabStopItem with a 0 WhichId
    so its clones are useless
    
    Change-Id: I725bec90d8915b3546afeed590f21ebdbbdaa355
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86579
    Tested-by: Jenkins
    Reviewed-by: Adolfo Jayme Barrientos <fitojb at ubuntu.com>

diff --git a/cui/source/tabpages/tabstpge.cxx b/cui/source/tabpages/tabstpge.cxx
index f9b7205247cb..9e7001c44404 100644
--- a/cui/source/tabpages/tabstpge.cxx
+++ b/cui/source/tabpages/tabstpge.cxx
@@ -520,7 +520,7 @@ IMPL_LINK_NOARG(SvxTabulatorTabPage, DelAllHdl_Impl, weld::Button&, void)
 {
     if ( aNewTabs->Count() )
     {
-        aNewTabs = std::make_unique<SvxTabStopItem>( 0 );
+        aNewTabs = std::make_unique<SvxTabStopItem>(GetWhich(SID_ATTR_TABSTOP));
         InitTabPos_Impl();
     }
 }


More information about the Libreoffice-commits mailing list