[Libreoffice-commits] core.git: logerrit

Guilhem Moulin (via logerrit) logerrit at kemper.freedesktop.org
Wed Jan 15 22:51:49 UTC 2020


 logerrit |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 9276b117355c098bdfbe3cfa207aca869bf4bd01
Author:     Guilhem Moulin <guilhem at libreoffice.org>
AuthorDate: Wed Jan 15 05:22:20 2020 +0100
Commit:     Guilhem Moulin <guilhem at libreoffice.org>
CommitDate: Wed Jan 15 23:51:17 2020 +0100

    logerrit: atomically create ~/.ssh with restrictive mode
    
    AFAICT `mkdir [-m mode]` is already defined in POSIX.1-1990.
    
    Change-Id: I159578eac16398f16d55578fbd818906b77cf373
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86852
    Tested-by: Jenkins
    Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas at libreoffice.org>
    Reviewed-by: Michael Stahl <michael.stahl at cib.de>

diff --git a/logerrit b/logerrit
index 33f45dc44c73..04ce54414904 100755
--- a/logerrit
+++ b/logerrit
@@ -76,8 +76,7 @@ case "$1" in
 	created_ssh=
 	if ! test -d $ssh_home; then
 	    echo "It appears that you have no ssh setup, running ssh-keygen to create that:"
-	    mkdir $ssh_home
-	    chmod 0700 $ssh_home
+	    mkdir -m0700 "$ssh_home"
 	    created_ssh=TRUE
 	    echo
 	    echo "Hit enter to generate an ssh key - you will need to enter a pass-phrase"


More information about the Libreoffice-commits mailing list