[Libreoffice-commits] core.git: formula/IwyuFilter_formula.yaml formula/qa formula/source

Gabor Kelemen (via logerrit) logerrit at kemper.freedesktop.org
Mon Jan 20 10:47:41 UTC 2020 

 formula/IwyuFilter_formula.yaml             |    2 ++
 formula/qa/unit/formula-dialogs-test.cxx    |    3 ---
 formula/source/core/api/FormulaCompiler.cxx |    3 ---
 formula/source/core/api/token.cxx           |    2 --
 formula/source/ui/dlg/formula.cxx           |    7 -------
 formula/source/ui/dlg/funcpage.cxx          |    4 ----
 formula/source/ui/dlg/funcutl.cxx           |    2 --
 formula/source/ui/dlg/parawin.cxx           |    4 ----
 formula/source/ui/dlg/structpg.cxx          |    4 ----
 formula/source/ui/dlg/structpg.hxx          |    1 -
 10 files changed, 2 insertions(+), 30 deletions(-)

New commits:
commit c392aa2fbac26e5656575c3f0295a65bd7f11252
Author:     Gabor Kelemen <kelemen.gabor2 at nisz.hu>
AuthorDate: Wed Jan 15 23:43:24 2020 +0100
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Mon Jan 20 11:47:08 2020 +0100

    tdf#42949 Fix IWYU warnings in formula/
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: I6cfd3036481b8f76da73e46ac2b4b4a879f98cee
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86894
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/formula/IwyuFilter_formula.yaml b/formula/IwyuFilter_formula.yaml
new file mode 100644
index 000000000000..a58c6e3d818c
--- /dev/null
+++ b/formula/IwyuFilter_formula.yaml
@@ -0,0 +1,2 @@
+---
+assumeFilename: formula/source/core/api/FormulaCompiler.cxx
diff --git a/formula/qa/unit/formula-dialogs-test.cxx b/formula/qa/unit/formula-dialogs-test.cxx
index 127b8fe21b16..29262e53dac5 100644
--- a/formula/qa/unit/formula-dialogs-test.cxx
+++ b/formula/qa/unit/formula-dialogs-test.cxx
@@ -9,9 +9,6 @@
 
 #include <sal/config.h>
 #include <test/screenshot_test.hxx>
-#include <rtl/strbuf.hxx>
-#include <osl/file.hxx>
-#include <sfx2/app.hxx>
 #include <vcl/abstdlg.hxx>
 
 using namespace ::com::sun::star;
diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx
index 2c18b8fd3567..9de565ea6179 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -17,7 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 #include <sal/macros.h>
-#include <sal/alloca.h>
 #include <sal/log.hxx>
 #include <formula/FormulaCompiler.hxx>
 #include <formula/errorcodes.hxx>
@@ -29,12 +28,10 @@
 #include <osl/mutex.hxx>
 
 #include <svl/zforlist.hxx>
-#include <unotools/resmgr.hxx>
 #include <unotools/charclass.hxx>
 #include <com/sun/star/sheet/FormulaOpCodeMapEntry.hpp>
 #include <com/sun/star/sheet/FormulaMapGroup.hpp>
 #include <com/sun/star/sheet/FormulaMapGroupSpecialOffset.hpp>
-#include <rtl/strbuf.hxx>
 #include <algorithm>
 
 namespace formula
diff --git a/formula/source/core/api/token.cxx b/formula/source/core/api/token.cxx
index 88c5d3a57de1..54d0b52eb4b5 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -18,8 +18,6 @@
  */
 
 
-#include <cstddef>
-#include <cstdio>
 #include <algorithm>
 
 #include <string.h>
diff --git a/formula/source/ui/dlg/formula.cxx b/formula/source/ui/dlg/formula.cxx
index 5f9a94f42699..2229377b3089 100644
--- a/formula/source/ui/dlg/formula.cxx
+++ b/formula/source/ui/dlg/formula.cxx
@@ -18,16 +18,10 @@
  */
 
 #include <memory>
-#include <sfx2/dispatch.hxx>
-#include <sfx2/docfile.hxx>
 #include <sfx2/viewfrm.hxx>
-#include <vcl/idle.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
 
-#include <svl/stritem.hxx>
-#include <svl/zforlist.hxx>
-#include <svl/eitem.hxx>
 #include <sal/log.hxx>
 
 #include <unotools/charclass.hxx>
@@ -51,7 +45,6 @@
 #include <com/sun/star/sheet/FormulaMapGroupSpecialOffset.hpp>
 #include <com/sun/star/sheet/XFormulaOpCodeMapper.hpp>
 #include <com/sun/star/sheet/XFormulaParser.hpp>
-#include <com/sun/star/beans/XPropertySet.hpp>
 #include <map>
 
 // For tab page
diff --git a/formula/source/ui/dlg/funcpage.cxx b/formula/source/ui/dlg/funcpage.cxx
index 92035c709a3d..58279485d09b 100644
--- a/formula/source/ui/dlg/funcpage.cxx
+++ b/formula/source/ui/dlg/funcpage.cxx
@@ -17,10 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include <sfx2/dispatch.hxx>
-#include <sfx2/docfile.hxx>
-#include <svl/zforlist.hxx>
-#include <svl/stritem.hxx>
 #include <vcl/event.hxx>
 #include <vcl/svapp.hxx>
 #include <formula/IFunctionDescription.hxx>
diff --git a/formula/source/ui/dlg/funcutl.cxx b/formula/source/ui/dlg/funcutl.cxx
index 8e57f8574ddf..2cfc7deccec6 100644
--- a/formula/source/ui/dlg/funcutl.cxx
+++ b/formula/source/ui/dlg/funcutl.cxx
@@ -17,7 +17,6 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include <vcl/svapp.hxx>
 #include <vcl/event.hxx>
 
 #include <formula/funcutl.hxx>
@@ -27,7 +26,6 @@
 #include <strings.hrc>
 #include <bitmaps.hlst>
 #include <core_resource.hxx>
-#include <com/sun/star/accessibility/AccessibleRole.hpp>
 
 namespace formula
 {
diff --git a/formula/source/ui/dlg/parawin.cxx b/formula/source/ui/dlg/parawin.cxx
index 9d8f1be6e0b2..c77a21175acd 100644
--- a/formula/source/ui/dlg/parawin.cxx
+++ b/formula/source/ui/dlg/parawin.cxx
@@ -18,14 +18,10 @@
  */
 
 #include <comphelper/string.hxx>
-#include <svl/zforlist.hxx>
-#include <svl/stritem.hxx>
-#include <vcl/settings.hxx>
 #include <vcl/svapp.hxx>
 #include <sal/log.hxx>
 
 #include "parawin.hxx"
-#include <formula/formdata.hxx>
 #include <formula/IFunctionDescription.hxx>
 #include <formula/funcvarargs.h>
 #include <strings.hrc>
diff --git a/formula/source/ui/dlg/structpg.cxx b/formula/source/ui/dlg/structpg.cxx
index f35d34a5a336..432f2a9bdd5b 100644
--- a/formula/source/ui/dlg/structpg.cxx
+++ b/formula/source/ui/dlg/structpg.cxx
@@ -17,14 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include <svl/zforlist.hxx>
-#include <svl/stritem.hxx>
 #include <vcl/svapp.hxx>
 
 #include "structpg.hxx"
-#include <formula/formdata.hxx>
 #include <formula/formula.hxx>
-#include <formula/IFunctionDescription.hxx>
 #include <formula/token.hxx>
 #include <bitmaps.hlst>
 
diff --git a/formula/source/ui/dlg/structpg.hxx b/formula/source/ui/dlg/structpg.hxx
index 1765254ccfe7..935b321d0443 100644
--- a/formula/source/ui/dlg/structpg.hxx
+++ b/formula/source/ui/dlg/structpg.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_FORMULA_SOURCE_UI_DLG_STRUCTPG_HXX
 #define INCLUDED_FORMULA_SOURCE_UI_DLG_STRUCTPG_HXX
 
-#include <formula/IFunctionDescription.hxx>
 #include <vcl/weld.hxx>
 
 namespace formula

More information about the Libreoffice-commits mailing list