[Libreoffice-commits] core.git: vcl/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Mon Jan 20 15:55:59 UTC 2020


 vcl/source/filter/ipdf/pdfread.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 74d1991352bc21ec46759a932887e08a25bb5387
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Mon Jan 20 13:05:39 2020 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Mon Jan 20 16:55:29 2020 +0100

    Use properly typed var to iterate over FPDF_GetPageCount
    
    ...which, according to <https://pdfium.patagames.com/help/html/
    M_Patagames_Pdf_Pdfium_FPDF_GetPageCount.htm>, returns int.   The code had oddly
    been like this since it was introduced with
    9194f019afb0599d5e72476786fabfa996e07f20 "pdfium: Import PDF with unloaded
    images."
    
    Change-Id: If8aad3c0bfbecdedea9511cff17e125fb1938f90
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87067
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/vcl/source/filter/ipdf/pdfread.cxx b/vcl/source/filter/ipdf/pdfread.cxx
index 6ace744ec1eb..38c53fc36fc0 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -325,7 +325,7 @@ size_t ImportPDFUnloaded(const OUString& rURL, std::vector<std::pair<Graphic, Si
     // dummy Bitmap
     Bitmap aBitmap(Size(1, 1), 24);
 
-    for (size_t nPageIndex = 0; nPageIndex < static_cast<size_t>(nPageCount); ++nPageIndex)
+    for (int nPageIndex = 0; nPageIndex < nPageCount; ++nPageIndex)
     {
         double fPageWidth = 0;
         double fPageHeight = 0;


More information about the Libreoffice-commits mailing list