[Libreoffice-commits] core.git: avmedia/source
Stephan Bergmann (via logerrit)
logerrit at kemper.freedesktop.org
Wed Jan 29 15:47:23 UTC 2020
avmedia/source/gstreamer/gstplayer.cxx | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 024f3691a2ea865121fbdff6bb6b3d86120f5909
Author: Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Jan 29 15:45:59 2020 +0100
Commit: Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Jan 29 16:46:51 2020 +0100
There should be no need for o3tl::make_unsigned here
...to avoid hypothetical warnings when comparing an unsigned value to a signed
constant
Change-Id: Ife9f0be863443ea06fcd6dd49aba651f49659f02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87690
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
diff --git a/avmedia/source/gstreamer/gstplayer.cxx b/avmedia/source/gstreamer/gstplayer.cxx
index bf934235a992..bba734b34c79 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -30,7 +30,6 @@
#include <math.h>
#include <cppuhelper/supportsservice.hxx>
-#include <o3tl/safeint.hxx>
#include <sal/log.hxx>
#include <rtl/string.hxx>
#include <salhelper/thread.hxx>
@@ -126,7 +125,7 @@ void MissingPluginInstaller::report(
return;
}
std::size_t len = std::strlen(det);
- if (len > o3tl::make_unsigned(SAL_MAX_INT32)) {
+ if (len > SAL_MAX_INT32) {
SAL_WARN("avmedia.gstreamer", "detail string too long");
g_free(det);
return;
More information about the Libreoffice-commits
mailing list