[Libreoffice-commits] core.git: sax/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Wed Jul 1 19:30:29 UTC 2020


 sax/source/expatwrap/sax_expat.cxx  |    2 +-
 sax/source/tools/converter.cxx      |   12 ++++++------
 sax/source/tools/fastserializer.cxx |   18 +++++++++---------
 3 files changed, 16 insertions(+), 16 deletions(-)

New commits:
commit 5e3241cf1659a441af28f1e1adc8da2719e7cb85
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Jul 1 19:54:23 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Jul 1 21:29:44 2020 +0200

    Upcoming improved loplugin:staticanonymous -> redundantstatic: sax
    
    Change-Id: I9f6a90d41d33350d0ebb72b1bf67527d24ab1dd2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97649
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sax/source/expatwrap/sax_expat.cxx b/sax/source/expatwrap/sax_expat.cxx
index b80ebf033782..439166cb5641 100644
--- a/sax/source/expatwrap/sax_expat.cxx
+++ b/sax/source/expatwrap/sax_expat.cxx
@@ -140,7 +140,7 @@ struct Entity
 };
 
 
-static constexpr OUStringLiteral gsCDATA = "CDATA";
+constexpr OUStringLiteral gsCDATA = "CDATA";
 
 class SaxExpatParser_Impl
 {
diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index 1f070e0260e1..cea2c41e9caf 100644
--- a/sax/source/tools/converter.cxx
+++ b/sax/source/tools/converter.cxx
@@ -42,11 +42,11 @@ using namespace ::com::sun::star::i18n;
 
 namespace sax {
 
-static const char* const gpsMM = "mm";
-static const char* const gpsCM = "cm";
-static const char* const gpsPT = "pt";
-static const char* const gpsINCH = "in";
-static const char* const gpsPC = "pc";
+const char* const gpsMM = "mm";
+const char* const gpsCM = "cm";
+const char* const gpsPT = "pt";
+const char* const gpsINCH = "in";
+const char* const gpsPC = "pc";
 
 const sal_Int8 XML_MAXDIGITSCOUNT_TIME = 14;
 
@@ -492,7 +492,7 @@ bool Converter::convertColor( sal_Int32& rColor, const OUString& rValue )
     return true;
 }
 
-static const char aHexTab[] = "0123456789abcdef";
+const char aHexTab[] = "0123456789abcdef";
 
 /** convert color to string */
 void Converter::convertColor( OUStringBuffer& rBuffer, sal_Int32 nColor )
diff --git a/sax/source/tools/fastserializer.cxx b/sax/source/tools/fastserializer.cxx
index 202641999b78..792784eb2a9c 100644
--- a/sax/source/tools/fastserializer.cxx
+++ b/sax/source/tools/fastserializer.cxx
@@ -42,15 +42,15 @@ using ::com::sun::star::io::XOutputStream;
 // number of characters without terminating 0
 #define N_CHARS(string) (SAL_N_ELEMENTS(string) - 1)
 
-static const char sClosingBracket[] = ">";
-static const char sSlashAndClosingBracket[] = "/>";
-static const char sColon[] = ":";
-static const char sOpeningBracket[] = "<";
-static const char sOpeningBracketAndSlash[] = "</";
-static const char sQuote[] = "\"";
-static const char sEqualSignAndQuote[] = "=\"";
-static const char sSpace[] = " ";
-static const char sXmlHeader[] = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n";
+const char sClosingBracket[] = ">";
+const char sSlashAndClosingBracket[] = "/>";
+const char sColon[] = ":";
+const char sOpeningBracket[] = "<";
+const char sOpeningBracketAndSlash[] = "</";
+const char sQuote[] = "\"";
+const char sEqualSignAndQuote[] = "=\"";
+const char sSpace[] = " ";
+const char sXmlHeader[] = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n";
 
 namespace sax_fastparser {
     FastSaxSerializer::FastSaxSerializer( const css::uno::Reference< css::io::XOutputStream >& xOutputStream )


More information about the Libreoffice-commits mailing list