[Libreoffice-commits] core.git: sw/source

Szymon KÅ‚os (via logerrit) logerrit at kemper.freedesktop.org
Thu Jul 2 11:16:37 UTC 2020


 sw/source/uibase/app/docstyle.cxx |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit 4bc6799cbf00715b2a0a8f5553d8600ca04c3882
Author:     Szymon Kłos <szymon.klos at collabora.com>
AuthorDate: Tue Jun 16 11:42:13 2020 +0200
Commit:     Szymon Kłos <szymon.klos at collabora.com>
CommitDate: Thu Jul 2 13:15:55 2020 +0200

    Getting styles info shouldnt set document modification state
    
    Getter function modified document's 'is modified' state
    and broadcasted it due to internal styles creation/delete
    
    That caused spam of SwCursorShell::UpdateCursor calls
    when styles preview widget was used in the notebookbar.
    
    Change-Id: I22ee4e820adf79f6e816cb35161cb21f26abb2b0
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96921
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97733
    Tested-by: Jenkins

diff --git a/sw/source/uibase/app/docstyle.cxx b/sw/source/uibase/app/docstyle.cxx
index 458c01d8d725..3a933b50bdd3 100644
--- a/sw/source/uibase/app/docstyle.cxx
+++ b/sw/source/uibase/app/docstyle.cxx
@@ -1289,7 +1289,14 @@ std::unique_ptr<SfxItemSet> SwDocStyleSheet::GetItemSetForPreview()
         // time, return one "flattened" item set that contains all items from
         // all parents.
         std::unique_ptr<SfxItemSet> pRet;
+
+        bool bModifiedEnabled = rDoc.getIDocumentState().IsEnableSetModified();
+        rDoc.getIDocumentState().SetEnableSetModified(false);
+
         FillStyleSheet(FillPreview, &pRet);
+
+        rDoc.getIDocumentState().SetEnableSetModified(bModifiedEnabled);
+
         assert(pRet);
         return pRet;
     }


More information about the Libreoffice-commits mailing list