[Libreoffice-commits] online.git: loleaflet/src

Dennis Francis (via logerrit) logerrit at kemper.freedesktop.org
Sun Jul 5 08:06:06 UTC 2020


 loleaflet/src/layer/tile/CalcTileLayer.js |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 36f06284407aa9d6145410d0e74350030fcb732a
Author:     Dennis Francis <dennis.francis at collabora.com>
AuthorDate: Sat May 16 18:07:56 2020 +0530
Commit:     Dennis Francis <dennis.francis at collabora.com>
CommitDate: Sun Jul 5 10:05:46 2020 +0200

    call refreshViewData() on setpart message...
    
    if the part is not hidden. The member _selectedPart is already set
    to the new part in Parts.js's setPart(), as a result the code inside
    the if was never getting executed. There is no need to call
    map.setPart() as this was also done in Parts.js setPart(), and finally
    there are no handler for 'setpart' event as of now, so lets remove the
    fire() call too. All of this was not a problem when the
    '.uno:ViewRowColumnHeader' data source was used, because that data
    was getting requested unintentionally as part of related scroll events
    during a sheet switch.
    
    Change-Id: I3ea3916ba738d9616e822659fc64903eda8f99cf
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97952
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Dennis Francis <dennis.francis at collabora.com>

diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js b/loleaflet/src/layer/tile/CalcTileLayer.js
index 030152594..1d206711e 100644
--- a/loleaflet/src/layer/tile/CalcTileLayer.js
+++ b/loleaflet/src/layer/tile/CalcTileLayer.js
@@ -364,9 +364,7 @@ L.CalcTileLayer = L.TileLayer.extend({
 
 	_onSetPartMsg: function (textMsg) {
 		var part = parseInt(textMsg.match(/\d+/g)[0]);
-		if (part !== this._selectedPart && !this.isHiddenPart(part)) {
-			this._map.setPart(part, true);
-			this._map.fire('setpart', {selectedPart: this._selectedPart});
+		if (!this.isHiddenPart(part)) {
 			this.refreshViewData(undefined, true /* sheetGeometryChanged */);
 		}
 	},


More information about the Libreoffice-commits mailing list