[Libreoffice-commits] core.git: cui/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Thu Jul 9 10:43:48 UTC 2020


 cui/source/dialogs/hltpbase.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2a691bfb8c749d25d8776f16977441f927cd3cd7
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Jul 9 09:55:38 2020 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Jul 9 12:42:59 2020 +0200

    cid#1465235 Dereference null return value
    
    Change-Id: I73efddfeca873e43f1505790eebf260c27e248de
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98408
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/cui/source/dialogs/hltpbase.cxx b/cui/source/dialogs/hltpbase.cxx
index b3c7b076f1ca..63d3eb1738c1 100644
--- a/cui/source/dialogs/hltpbase.cxx
+++ b/cui/source/dialogs/hltpbase.cxx
@@ -331,7 +331,7 @@ IMPL_LINK_NOARG(SvxHyperlinkTabPageBase, ClickScriptHdl_Impl, weld::Button&, voi
     SvxHyperlinkItem *pHyperlinkItem = const_cast<SvxHyperlinkItem*>(static_cast<const SvxHyperlinkItem *>(
                                        GetItemSet().GetItem (SID_HYPERLINK_GETLINK)));
 
-    if ( pHyperlinkItem->GetMacroEvents() == HyperDialogEvent::NONE )
+    if (!pHyperlinkItem || pHyperlinkItem->GetMacroEvents() == HyperDialogEvent::NONE)
         return;
 
     // get macros from itemset


More information about the Libreoffice-commits mailing list