[Libreoffice-commits] online.git: cypress_test/integration_tests

Tamás Zolnai (via logerrit) logerrit at kemper.freedesktop.org
Tue Jul 14 13:47:03 UTC 2020


 cypress_test/integration_tests/mobile/writer/shape_properties_spec.js |   50 ++++------
 1 file changed, 22 insertions(+), 28 deletions(-)

New commits:
commit af091dbb1add066d21485b6f134721a90716dfb5
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Tue Jul 14 15:16:18 2020 +0200
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Tue Jul 14 15:46:44 2020 +0200

    Revert "cypress: update writer shape related tests."
    
    This reverts commit f3572dc98828b1c5d617f3b503e76c7448fa5439.
    
    Change-Id: I2b12aaa4c4ace0119be98e6d46ce95fdd1ac0f73
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98732
    Tested-by: Jenkins
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>

diff --git a/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js b/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
index e9c2aeede..01dcd3c71 100644
--- a/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
+++ b/cypress_test/integration_tests/mobile/writer/shape_properties_spec.js
@@ -43,32 +43,15 @@ describe('Change shape properties via mobile wizard.', function() {
 	function triggerNewSVG() {
 		mobileHelper.closeMobileWizard();
 
-		// Remove selection first with clicking next to handler
-		cy.get('.leaflet-drag-transform-marker.drag-marker--0')
-			.then(function(items) {
-				var XPos = items[0].getBoundingClientRect().left;
-				var YPos = items[0].getBoundingClientRect().top;
-				// Sometimes selection is persistent, so click more times
-				// to achive actual deselection.
-				cy.get('body')
-					.click(XPos - 10, YPos);
-
-				cy.get('body')
-					.dblclick(XPos - 10, YPos);
-
-				cy.get('.leaflet-drag-transform-marker')
-					.should('not.exist');
-
-				// Reselect the shape
-				cy.get('body')
-					.click(XPos + 20, YPos);
-
-				cy.get('body')
-					.click(XPos + 20, YPos);
-
-				cy.get('.leaflet-drag-transform-marker')
-					.should('exist');
-			});
+		// Change width
+		openPosSizePanel();
+
+		cy.get('#selectwidth .plus')
+			.should('be.visible');
+
+		helper.clickOnIdle('#selectwidth .plus');
+
+		mobileHelper.closeMobileWizard();
 	}
 
 	function openPosSizePanel() {
@@ -99,6 +82,7 @@ describe('Change shape properties via mobile wizard.', function() {
 	});
 
 	it('Change shape width.', function() {
+
 		openPosSizePanel();
 
 		cy.get('#selectwidth .spinfield')
@@ -114,6 +98,7 @@ describe('Change shape properties via mobile wizard.', function() {
 	});
 
 	it('Change shape height.', function() {
+
 		openPosSizePanel();
 
 		cy.get('#selectheight .spinfield')
@@ -170,7 +155,7 @@ describe('Change shape properties via mobile wizard.', function() {
 			.should('not.have.attr', 'd', defaultGeometry);
 
 		cy.get('.leaflet-pane.leaflet-overlay-pane svg g svg g g g path')
-			.should('have.attr', 'd', 'M 7955,4863 L 1963,10855 7955,10855 7955,4863 7955,4863 Z');
+			.should('have.attr', 'd', 'M 8010,4863 L 1963,10855 8010,10855 8010,4863 8010,4863 Z');
 	});
 
 	it('Trigger moving backward / forward', function() {
@@ -217,7 +202,7 @@ describe('Change shape properties via mobile wizard.', function() {
 			.should('have.length.greaterThan', 12);
 	});
 
-	it('Change line width', function() {
+	it.skip('Change line width', function() {
 		openLinePropertyPanel();
 
 		cy.get('#linewidth .spinfield')
@@ -229,6 +214,15 @@ describe('Change shape properties via mobile wizard.', function() {
 
 		cy.get('.leaflet-pane.leaflet-overlay-pane svg g svg g g g path[fill="none"]')
 			.should('have.attr', 'stroke-width', '141');
+
+		openLinePropertyPanel();
+
+		helper.clickOnIdle('#linewidth .minus');
+
+		triggerNewSVG();
+
+		cy.get('.leaflet-pane.leaflet-overlay-pane svg g svg g g g path[fill="none"]')
+			.should('have.attr', 'stroke-width', '88');
 	});
 
 	it('Change line transparency', function() {


More information about the Libreoffice-commits mailing list