[Libreoffice-commits] core.git: sw/qa

[Stephan Bergmann (via logerrit)]

 sw/qa/uitest/writer_tests3/hyperlinkdialog.py |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 1cdda798def040fe778348061c0e18b28aa0e6bd
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Jul 29 10:33:43 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Jul 29 13:28:30 2020 +0200

    Further timing issues with test_insert_hyperlink
    
    <https://ci.libreoffice.org/job/lo_ubsan/1709/> still failed with
    
    > FAIL: test_insert_hyperlink (hyperlinkdialog.HyperlinkDialog)
    > ----------------------------------------------------------------------
    > Traceback (most recent call last):
    >   File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests3/hyperlinkdialog.py", line 71, in test_insert_hyperlink
    >     self.assertEqual(get_state_as_dict(xindication)["Text"], "link")
    > AssertionError: '' != 'link'
    > + link
    >
    
    so try a fix similar to 27798238ecb200e0753b013c79df0e6c014c7a7a "uitest : Avoid
    any timing issue in test_insert_hyperlink"
    
    Change-Id: I04b1616f3c5028065aafadbd73e0e52ef220ce5e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99669
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
index aafa6ae8d21e..6e3285b5f3ba 100644
--- a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
+++ b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
@@ -68,6 +68,7 @@ class HyperlinkDialog(UITestCase):
 
         xindication = xDialog.getChild("indication")
         xindication.executeAction("TYPE", mkPropertyValues({"TEXT": "link"}))
+        self.ui_test.wait_until_property_is_updated(xindication, "Text", "link")
         self.assertEqual(get_state_as_dict(xindication)["Text"], "link")
 
         xok = xDialog.getChild("ok")