[Libreoffice-commits] online.git: cypress_test/integration_tests cypress_test/Makefile.am

[Tamás Zolnai (via logerrit)]

 cypress_test/Makefile.am                                                  |    1 
 cypress_test/integration_tests/multiuser/sidebar_visibility_user2_spec.js |   11 +---------
 2 files changed, 3 insertions(+), 9 deletions(-)

New commits:
commit 1604fa99f852767ade64bcdea34b34aeae2ad470
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Thu Jul 30 12:01:00 2020 +0200
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Fri Jul 31 12:51:22 2020 +0200

    cypress: update sidebar visibility test.
    
    Test less which might make this test more stable.
    
    Change-Id: Icf11af96bc5d21a14f0a74a641ffed3f91b6e482
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99783
    Tested-by: Jenkins
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>

diff --git a/cypress_test/Makefile.am b/cypress_test/Makefile.am
index 1908215b0..9d30d655d 100644
--- a/cypress_test/Makefile.am
+++ b/cypress_test/Makefile.am
@@ -64,6 +64,7 @@ DEKSTOP_TEST_FILES=$(subst $(DESKTOP_TEST_FOLDER)/,,$(wildcard $(DESKTOP_TEST_FO
 
 MULTIUSER_TESTS= \
 	paragraph_prop \
+	sidebar_visibility \
 	simultaneous_typing
 
 MOBILE_TEST_FILES_DONE= \
diff --git a/cypress_test/integration_tests/multiuser/sidebar_visibility_user2_spec.js b/cypress_test/integration_tests/multiuser/sidebar_visibility_user2_spec.js
index 4d28c0aa6..d98608769 100644
--- a/cypress_test/integration_tests/multiuser/sidebar_visibility_user2_spec.js
+++ b/cypress_test/integration_tests/multiuser/sidebar_visibility_user2_spec.js
@@ -1,7 +1,6 @@
 /* global describe it cy beforeEach require afterEach */
 
 var helper = require('../common/helper');
-var desktopHelper = require('../common/desktop_helper');
 
 describe('Sidebar visibility: user-2.', function() {
 	var testFileName = 'sidebar_visibility.odt';
@@ -38,9 +37,6 @@ describe('Sidebar visibility: user-2.', function() {
 		cy.get('#sidebar-panel')
 			.should('be.visible');
 
-		// Hide sidebar
-		desktopHelper.hideSidebar();
-
 		// Change paragraph alignment to trigger user-1 actions
 		cy.get('#tb_editbar_item_rightpara .w2ui-button')
 			.click();
@@ -49,12 +45,9 @@ describe('Sidebar visibility: user-2.', function() {
 		cy.get('#tb_editbar_item_justifypara .w2ui-button')
 			.should('have.class', 'checked');
 
-		// sidebar should be still invisible (user-1 showed his own sidebar)
+		// sidebar should be still visible
 		cy.get('#sidebar-panel')
-			.should('not.be.visible');
-
-		// Show sidebar again
-		desktopHelper.showSidebar();
+			.should('be.visible');
 
 		// Change paragraph alignment to trigger user-1 actions
 		cy.get('#tb_editbar_item_leftpara .w2ui-button')