[Libreoffice-commits] online.git: cypress_test/integration_tests

Tamás Zolnai (via logerrit) logerrit at kemper.freedesktop.org
Fri Jul 31 17:06:28 UTC 2020


 cypress_test/integration_tests/common/helper.js                   |    3 +++
 cypress_test/integration_tests/mobile/calc/bottom_toolbar_spec.js |    2 ++
 2 files changed, 5 insertions(+)

New commits:
commit f05e53af0768e0530db1801788b70664c5ccc3de
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Fri Jul 31 15:30:37 2020 +0200
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Fri Jul 31 19:06:09 2020 +0200

    cypress: fix calc's bottom toolbar test.
    
    Fix 'detached from DOM' error. In Calc we have a small
    flickering of the bottom toolbar, because we have also
    the formula bar appearing after editing is enabled.
    
    Change-Id: If642d6ae0aae0fcc761382567a2d2e37ad3bf486
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99888
    Tested-by: Jenkins
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>

diff --git a/cypress_test/integration_tests/common/helper.js b/cypress_test/integration_tests/common/helper.js
index 675391ea9..a547eaf6a 100644
--- a/cypress_test/integration_tests/common/helper.js
+++ b/cypress_test/integration_tests/common/helper.js
@@ -300,6 +300,9 @@ function imageShouldBeFullWhiteOrNot(selector, fullWhite = true) {
 
 function waitUntilIdle(selector, content, waitingTime = 1000) {
 	cy.log('Waiting item to be idle - start.');
+	cy.log('Param - selector: ' + selector);
+	cy.log('Param - content: ' + content);
+	cy.log('Param - waitingTime: ' + waitingTime);
 
 	var item;
 	var waitOnce = 250;
diff --git a/cypress_test/integration_tests/mobile/calc/bottom_toolbar_spec.js b/cypress_test/integration_tests/mobile/calc/bottom_toolbar_spec.js
index e62a05501..68a4ae835 100644
--- a/cypress_test/integration_tests/mobile/calc/bottom_toolbar_spec.js
+++ b/cypress_test/integration_tests/mobile/calc/bottom_toolbar_spec.js
@@ -15,6 +15,8 @@ describe('Interact with bottom toolbar.', function() {
 		// Click on edit button
 		mobileHelper.enableEditingMobile();
 
+		helper.waitUntilIdle('#toolbar-down');
+
 		calcHelper.clickOnFirstCell();
 	}
 


More information about the Libreoffice-commits mailing list