[Libreoffice-commits] core.git: sc/source

Luboš Luňák (via logerrit) logerrit at kemper.freedesktop.org
Tue Jun 2 13:38:31 UTC 2020


 sc/source/core/data/documen2.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 861fbd998f2b526c2aea073c9471613bf728fa75
Author:     Luboš Luňák <l.lunak at collabora.com>
AuthorDate: Thu May 28 16:18:58 2020 +0200
Commit:     Luboš Luňák <l.lunak at collabora.com>
CommitDate: Tue Jun 2 15:37:58 2020 +0200

    purge shared string pool if ScDocument is closed (tdf#125428)
    
    Especially with the testcases given in the bugreport the undo history
    would keep many unused shared strings.
    
    Change-Id: I57fcad73532fdcbad0a1298fbd06cb35c058bf96
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95045
    Tested-by: Jenkins
    Reviewed-by: Luboš Luňák <l.lunak at collabora.com>

diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index ac89e288bda1..afacfecc4640 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -394,6 +394,9 @@ ScDocument::~ScDocument()
     SAL_WARN_IF( pAutoNameCache, "sc.core", "AutoNameCache still set in dtor" );
 
     mpFormulaGroupCxt.reset();
+    // Purge unused items if the string pool will be still used (e.g. by undo history).
+    if(mpCellStringPool.use_count() > 1)
+        mpCellStringPool->purge();
     mpCellStringPool.reset();
 }
 


More information about the Libreoffice-commits mailing list