[Libreoffice-commits] core.git: uitest/ui_logger_dsl

[Shiko (via logerrit)]

 uitest/ui_logger_dsl/dsl_core.py |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

New commits:
commit a68e4fcbcfb7c78c6247d24ecb141e1d87d7c46e
Author:     Shiko <aelshreif7 at gmail.com>
AuthorDate: Tue Jun 2 06:38:52 2020 +0200
Commit:     Ahmed ElShreif <aelshreif7 at gmail.com>
CommitDate: Wed Jun 3 08:44:21 2020 +0200

    uitest: avoid defining the same object multiple time in in math
    
    Change-Id: I1ee5cde133390ca285bb154e6a373e0e5bc1cbed
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95334
    Tested-by: Jenkins
    Reviewed-by: Ahmed ElShreif <aelshreif7 at gmail.com>

diff --git a/uitest/ui_logger_dsl/dsl_core.py b/uitest/ui_logger_dsl/dsl_core.py
index 7390ec03f46a..644fc06e73dd 100644
--- a/uitest/ui_logger_dsl/dsl_core.py
+++ b/uitest/ui_logger_dsl/dsl_core.py
@@ -76,6 +76,7 @@ class ul_Compiler:
             "# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-\n\n"
             + "from uitest.framework import UITestCase\n"
             + "from libreoffice.uno.propertyvalue import mkPropertyValues\n"
+            + "from uitest.uihelper.common import get_state_as_dict\n"
             + "import importlib\n\n"
             + "class TestClass(UITestCase):\n"
             + tab
@@ -806,14 +807,7 @@ class ul_Compiler:
         # this put a prefix of char 'x' to avoid variable with name equal to number only
         element_name="x"+str(math_element_selector.element_no)
 
-        line = (
-            double_tab
-            + str(element_name)
-            + ' = element_selector.getChild("'
-            + str(math_element_selector.element_no)
-            + '")\n'
-        )
-        self.variables.append(line)
+        self.init_Object(element_name,str(math_element_selector.element_no),"element_selector")
 
         self.write_line_without_parameters(
             str(element_name), "SELECT", "tuple"