[Libreoffice-commits] online.git: cypress_test/integration_tests

Tamás Zolnai (via logerrit) logerrit at kemper.freedesktop.org
Thu Jun 4 10:05:35 UTC 2020


 cypress_test/integration_tests/mobile/impress/apply_font_spec.js            |   92 +--------
 cypress_test/integration_tests/mobile/impress/apply_paragraph_props_spec.js |  102 ++--------
 cypress_test/integration_tests/mobile/impress/impress_mobile_helper.js      |   73 +++++++
 cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js      |   50 +---
 4 files changed, 131 insertions(+), 186 deletions(-)

New commits:
commit 8e9627a033f9e53a4e1b382678d634a926d88cf8
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Thu Jun 4 11:18:40 2020 +0200
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Thu Jun 4 12:05:17 2020 +0200

    cypress: extract some shared code in impress tests.
    
    Change-Id: I2683e894bccd46cdd847f95f8298595c733486a9
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95494
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>

diff --git a/cypress_test/integration_tests/mobile/impress/apply_font_spec.js b/cypress_test/integration_tests/mobile/impress/apply_font_spec.js
index 5540067ad..04a390887 100644
--- a/cypress_test/integration_tests/mobile/impress/apply_font_spec.js
+++ b/cypress_test/integration_tests/mobile/impress/apply_font_spec.js
@@ -1,7 +1,8 @@
-/* global describe it cy beforeEach require expect afterEach*/
+/* global describe it cy beforeEach require afterEach*/
 
 var helper = require('../../common/helper');
 var mobileHelper = require('../../common/mobile_helper');
+var impressMobileHelper = require('./impress_mobile_helper');
 
 describe('Apply font on text and on text shape.', function() {
 	var testFileName = 'apply_font.odp';
@@ -11,72 +12,15 @@ describe('Apply font on text and on text shape.', function() {
 
 		mobileHelper.enableEditingMobile();
 
-		selectTextShape();
+		impressMobileHelper.selectTextShapeInTheCenter();
 	});
 
 	afterEach(function() {
 		helper.afterAll(testFileName);
 	});
 
-	function selectTextShape() {
-		// Click on the center of the slide to select the text shape there
-		cy.get('#document-container')
-			.then(function(items) {
-				expect(items).to.have.length(1);
-				var XPos = (items[0].getBoundingClientRect().left + items[0].getBoundingClientRect().right) / 2;
-				var YPos = (items[0].getBoundingClientRect().top + items[0].getBoundingClientRect().bottom) / 2;
-				cy.get('body')
-					.click(XPos, YPos);
-			});
-
-		cy.get('.leaflet-drag-transform-marker')
-			.should('be.visible');
-
-		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page g')
-			.should('have.class', 'com.sun.star.drawing.TextShape');
-	}
-
-	function selectTextOfShape() {
-		// Double click onto the selected shape
-		cy.get('svg g .leaflet-interactive')
-			.then(function(items) {
-				expect(items).to.have.length(1);
-				var XPos = (items[0].getBoundingClientRect().left + items[0].getBoundingClientRect().right) / 2;
-				var YPos = (items[0].getBoundingClientRect().top + items[0].getBoundingClientRect().bottom) / 2;
-				cy.get('body')
-					.dblclick(XPos, YPos);
-			});
-
-		cy.get('.leaflet-cursor.blinking-cursor')
-			.should('exist');
-
-		helper.selectAllText(false);
-	}
-
 	function triggerNewSVG() {
-		mobileHelper.closeMobileWizard();
-
-		// Remove selection first with clicking next to the rotate handler
-		cy.get('.transform-handler--rotate')
-			.then(function(items) {
-				var XPos = items[0].getBoundingClientRect().left - 10;
-				var YPos = items[0].getBoundingClientRect().top;
-				cy.get('body')
-					.click(XPos, YPos);
-
-				cy.get('body')
-					.dblclick(XPos, YPos);
-			});
-
-		cy.get('.leaflet-drag-transform-marker')
-			.should('not.exist');
-
-		// If we click two fast on shape again
-		// then it steps into edit mode
-		cy.wait(200);
-
-		// Select text shape again which will retrigger a new SVG from core
-		selectTextShape();
+		impressMobileHelper.triggerNewSVGForShapeInTheCenter();
 	}
 
 	function openTextPropertiesPanel() {
@@ -334,7 +278,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Apply bold on selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -348,7 +292,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Apply italic on selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -362,7 +306,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Apply underline on selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -376,7 +320,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Apply strikeout on selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -390,7 +334,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Apply shadowed on selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -404,7 +348,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Change font name of selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -427,7 +371,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Change font size of selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -453,7 +397,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Grow font size of selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -470,7 +414,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Shrink font size of selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -490,7 +434,7 @@ describe('Apply font on text and on text shape.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextPosition tspan')
 			.should('have.attr', 'fill', 'rgb(0,0,0)');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -509,7 +453,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Apply highlight on selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -525,7 +469,7 @@ describe('Apply font on text and on text shape.', function() {
 
 		// TODO: highlight color is not in the SVG
 		// At least check the mobile wizard's state
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -534,7 +478,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Apply superscript on selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
@@ -555,7 +499,7 @@ describe('Apply font on text and on text shape.', function() {
 	});
 
 	it('Apply subscript on selected text.', function() {
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		mobileHelper.openMobileWizard();
 
diff --git a/cypress_test/integration_tests/mobile/impress/apply_paragraph_props_spec.js b/cypress_test/integration_tests/mobile/impress/apply_paragraph_props_spec.js
index 9547122e5..408ce035e 100644
--- a/cypress_test/integration_tests/mobile/impress/apply_paragraph_props_spec.js
+++ b/cypress_test/integration_tests/mobile/impress/apply_paragraph_props_spec.js
@@ -1,7 +1,8 @@
-/* global describe it cy beforeEach require expect afterEach*/
+/* global describe it cy beforeEach require afterEach*/
 
 var helper = require('../../common/helper');
 var mobileHelper = require('../../common/mobile_helper');
+var impressMobileHelper = require('./impress_mobile_helper');
 
 describe('Apply paragraph properties.', function() {
 	var testFileName = 'apply_paragraph_props.odp';
@@ -11,72 +12,15 @@ describe('Apply paragraph properties.', function() {
 
 		mobileHelper.enableEditingMobile();
 
-		selectTextShape();
+		impressMobileHelper.selectTextShapeInTheCenter();
 	});
 
 	afterEach(function() {
 		helper.afterAll(testFileName);
 	});
 
-	function selectTextShape() {
-		// Click on the center of the slide to select the text shape there
-		cy.get('#document-container')
-			.then(function(items) {
-				expect(items).to.have.length(1);
-				var XPos = (items[0].getBoundingClientRect().left + items[0].getBoundingClientRect().right) / 2;
-				var YPos = (items[0].getBoundingClientRect().top + items[0].getBoundingClientRect().bottom) / 2;
-				cy.get('body')
-					.click(XPos, YPos);
-			});
-
-		cy.get('.leaflet-drag-transform-marker')
-			.should('be.visible');
-
-		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page g')
-			.should('have.class', 'Outline');
-	}
-
 	function triggerNewSVG() {
-		mobileHelper.closeMobileWizard();
-
-		// Remove selection first with clicking next to the rotate handler
-		cy.get('.transform-handler--rotate')
-			.then(function(items) {
-				var XPos = items[0].getBoundingClientRect().left - 10;
-				var YPos = items[0].getBoundingClientRect().top;
-				cy.get('body')
-					.click(XPos, YPos);
-
-				cy.get('body')
-					.dblclick(XPos, YPos);
-			});
-
-		cy.get('.leaflet-drag-transform-marker')
-			.should('not.exist');
-
-		// If we click two fast on shape again
-		// then it steps into edit mode
-		cy.wait(200);
-
-		// Select text shape again which will retrigger a new SVG from core
-		selectTextShape();
-	}
-
-	function selectTextOfShape() {
-		// Double click onto the selected shape
-		cy.get('svg g .leaflet-interactive')
-			.then(function(items) {
-				expect(items).to.have.length(1);
-				var XPos = (items[0].getBoundingClientRect().left + items[0].getBoundingClientRect().right) / 2;
-				var YPos = (items[0].getBoundingClientRect().top + items[0].getBoundingClientRect().bottom) / 2;
-				cy.get('body')
-					.dblclick(XPos, YPos);
-			});
-
-		cy.get('.leaflet-cursor.blinking-cursor')
-			.should('exist');
-
-		helper.selectAllText(false);
+		impressMobileHelper.triggerNewSVGForShapeInTheCenter();
 	}
 
 	function openParagraphPropertiesPanel() {
@@ -281,7 +225,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph .TextPosition')
 			.should('have.attr', 'x', '1400');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Set right alignment first
 		openParagraphPropertiesPanel2();
@@ -295,7 +239,7 @@ describe('Apply paragraph properties.', function() {
 			.should('have.attr', 'x', '23586');
 
 		// Set left alignment
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -312,7 +256,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph .TextPosition')
 			.should('have.attr', 'x', '1400');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -329,7 +273,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph .TextPosition')
 			.should('have.attr', 'x', '1400');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Set right alignment first
 		openParagraphPropertiesPanel2();
@@ -342,7 +286,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph .TextPosition')
 			.should('have.attr', 'x', '23586');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Then set justified alignment
 		openParagraphPropertiesPanel2();
@@ -360,7 +304,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph .TextPosition')
 			.should('have.attr', 'y', '4834');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Set bottom alignment first
 		openParagraphPropertiesPanel2();
@@ -373,7 +317,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph .TextPosition')
 			.should('have.attr', 'y', '10811');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Then set top alignment
 		openParagraphPropertiesPanel2();
@@ -391,7 +335,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph .TextPosition')
 			.should('have.attr', 'y', '4834');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -409,7 +353,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .BulletChars')
 			.should('not.exist');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -427,7 +371,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextShape tspan')
 			.should('not.have.attr', 'ooo:numbering-type');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -444,7 +388,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph:nth-of-type(2) tspan')
 			.should('have.attr', 'y', '6600');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -465,7 +409,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph:nth-of-type(2) tspan')
 			.should('have.attr', 'y', '6600');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -486,7 +430,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph:nth-of-type(2) tspan')
 			.should('have.attr', 'y', '6600');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -498,7 +442,7 @@ describe('Apply paragraph properties.', function() {
 		cy.get('.leaflet-pane.leaflet-overlay-pane g.Page .TextParagraph:nth-of-type(2) tspan')
 			.should('have.attr', 'y', '6700');
 
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -516,7 +460,7 @@ describe('Apply paragraph properties.', function() {
 			.should('have.attr', 'x', '1400');
 
 		// Change right-to-left first
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -529,7 +473,7 @@ describe('Apply paragraph properties.', function() {
 			.should('have.attr', 'x', '23586');
 
 		// Change back to the default left-to-right
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -548,7 +492,7 @@ describe('Apply paragraph properties.', function() {
 			.should('not.exist');
 
 		// Apply bulleting first
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -563,7 +507,7 @@ describe('Apply paragraph properties.', function() {
 			.should('have.attr', 'transform', 'translate(1700,4563)');
 
 		// Change bulleting level
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
@@ -576,7 +520,7 @@ describe('Apply paragraph properties.', function() {
 			.should('have.attr', 'transform', 'translate(2900,4536)');
 
 		// Change bulleting level back to default
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		openParagraphPropertiesPanel2();
 
diff --git a/cypress_test/integration_tests/mobile/impress/impress_mobile_helper.js b/cypress_test/integration_tests/mobile/impress/impress_mobile_helper.js
index 8b1378917..141ad6b11 100644
--- a/cypress_test/integration_tests/mobile/impress/impress_mobile_helper.js
+++ b/cypress_test/integration_tests/mobile/impress/impress_mobile_helper.js
@@ -1 +1,74 @@
+/* globals cy expect require */
 
+var helper = require('../../common/helper');
+var mobileHelper = require('../../common/mobile_helper');
+
+function selectTextShapeInTheCenter() {
+	// Click on the center of the slide to select the text shape there
+	cy.get('#document-container')
+		.then(function(items) {
+			expect(items).to.have.length(1);
+			var XPos = (items[0].getBoundingClientRect().left + items[0].getBoundingClientRect().right) / 2;
+			var YPos = (items[0].getBoundingClientRect().top + items[0].getBoundingClientRect().bottom) / 2;
+			cy.get('body')
+				.click(XPos, YPos);
+		});
+
+	cy.get('.leaflet-drag-transform-marker')
+		.should('be.visible');
+
+	cy.get('.leaflet-pane.leaflet-overlay-pane g.Page g')
+		.should(function(shape) {
+			expect(shape.hasClass('com.sun.star.drawing.TextShape') ||
+				   shape.hasClass('Outline')).to.be.true;
+		});
+}
+
+function selectTextOfShape() {
+	// Double click onto the selected shape
+	cy.get('svg g .leaflet-interactive')
+		.then(function(items) {
+			expect(items).to.have.length(1);
+			var XPos = (items[0].getBoundingClientRect().left + items[0].getBoundingClientRect().right) / 2;
+			var YPos = (items[0].getBoundingClientRect().top + items[0].getBoundingClientRect().bottom) / 2;
+			cy.get('body')
+				.dblclick(XPos, YPos);
+		});
+
+	cy.get('.leaflet-cursor.blinking-cursor')
+		.should('exist');
+
+	helper.selectAllText(false);
+}
+
+function triggerNewSVGForShapeInTheCenter() {
+	mobileHelper.closeMobileWizard();
+
+	// Remove selection first with clicking next to the rotate handler
+	cy.get('.transform-handler--rotate')
+		.then(function(items) {
+			var XPos = items[0].getBoundingClientRect().left - 10;
+			var YPos = items[0].getBoundingClientRect().top;
+			// Sometimes selection is persistent, so click more times
+			// to achive actual deselection.
+			cy.get('body')
+				.click(XPos, YPos);
+
+			cy.get('body')
+				.dblclick(XPos, YPos);
+		});
+
+	cy.get('.leaflet-drag-transform-marker')
+		.should('not.exist');
+
+	// If we click too fast on the shape again
+	// then it steps into edit mode, might be a bug
+	cy.wait(200);
+
+	// Select text shape again which will retrigger a new SVG from core
+	selectTextShapeInTheCenter();
+}
+
+module.exports.selectTextShapeInTheCenter = selectTextShapeInTheCenter;
+module.exports.triggerNewSVGForShapeInTheCenter = triggerNewSVGForShapeInTheCenter;
+module.exports.selectTextOfShape = selectTextOfShape;
diff --git a/cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js b/cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js
index 1f32f2a33..3a20c0ec1 100644
--- a/cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js
+++ b/cypress_test/integration_tests/mobile/impress/insertion_wizard_spec.js
@@ -2,6 +2,7 @@
 
 var helper = require('../../common/helper');
 var mobileHelper = require('../../common/mobile_helper');
+var impressMobileHelper = require('./impress_mobile_helper');
 
 describe('Impress insertion wizard.', function() {
 	var testFileName = 'insertion_wizard.odp';
@@ -16,23 +17,6 @@ describe('Impress insertion wizard.', function() {
 		helper.afterAll(testFileName);
 	});
 
-	function selectTextOfShape() {
-		// Double click onto the selected shape
-		cy.get('svg g .leaflet-interactive')
-			.then(function(items) {
-				expect(items).to.have.length(1);
-				var XPos = (items[0].getBoundingClientRect().left + items[0].getBoundingClientRect().right) / 2;
-				var YPos = (items[0].getBoundingClientRect().top + items[0].getBoundingClientRect().bottom) / 2;
-				cy.get('body')
-					.dblclick(XPos, YPos);
-			});
-
-		cy.get('.leaflet-cursor.blinking-cursor')
-			.should('exist');
-
-		helper.selectAllText(false);
-	}
-
 	function selectionShouldBeTextShape() {
 		// Check that the shape is there
 		cy.get('.leaflet-pane.leaflet-overlay-pane svg')
@@ -215,7 +199,7 @@ describe('Impress insertion wizard.', function() {
 		selectionShouldBeTextShape();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		helper.expectTextForClipboard('Tap to edit text');
 	});
@@ -233,7 +217,7 @@ describe('Impress insertion wizard.', function() {
 		selectionShouldBeTextShape();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Check that we have a date in MM/DD/YY format
 		var regex = /\d{1,2}[/]\d{1,2}[/]\d{1,2}/;
@@ -253,7 +237,7 @@ describe('Impress insertion wizard.', function() {
 		selectionShouldBeTextShape();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Check that we have a date in MM/DD/YY format
 		var regex = /\d{1,2}[/]\d{1,2}[/]\d{1,2}/;
@@ -273,7 +257,7 @@ describe('Impress insertion wizard.', function() {
 		selectionShouldBeTextShape();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Check that we have a time in HH/MM/SS format
 		var regex = /\d{1,2}[:]\d{1,2}[:]\d{1,2}/;
@@ -293,7 +277,7 @@ describe('Impress insertion wizard.', function() {
 		selectionShouldBeTextShape();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Check that we have a time in HH/MM/SS format
 		var regex = /\d{1,2}[:]\d{1,2}[:]\d{1,2}/;
@@ -313,7 +297,7 @@ describe('Impress insertion wizard.', function() {
 		selectionShouldBeTextShape();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		helper.expectTextForClipboard('1');
 	});
@@ -331,7 +315,7 @@ describe('Impress insertion wizard.', function() {
 		selectionShouldBeTextShape();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		helper.expectTextForClipboard('Slide 1');
 	});
@@ -349,7 +333,7 @@ describe('Impress insertion wizard.', function() {
 		selectionShouldBeTextShape();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		helper.expectTextForClipboard('1');
 	});
@@ -378,7 +362,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		helper.expectTextForClipboard('some text');
 
@@ -398,7 +382,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Check that we have a date in MM/DD/YY format
 		var regex = /\d{1,2}[/]\d{1,2}[/]\d{1,2}/;
@@ -417,7 +401,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Check that we have a date in MM/DD/YY format
 		var regex = /\d{1,2}[/]\d{1,2}[/]\d{1,2}/;
@@ -436,7 +420,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Check that we have a time in HH/MM/SS format
 		var regex = /\d{1,2}[:]\d{1,2}[:]\d{1,2}/;
@@ -455,7 +439,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		// Check that we have a time in HH/MM/SS format
 		var regex = /\d{1,2}[:]\d{1,2}[:]\d{1,2}/;
@@ -474,7 +458,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		helper.expectTextForClipboard('1');
 	});
@@ -491,7 +475,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		helper.expectTextForClipboard('Slide 1');
 	});
@@ -508,7 +492,7 @@ describe('Impress insertion wizard.', function() {
 			.click();
 
 		// Check the text
-		selectTextOfShape();
+		impressMobileHelper.selectTextOfShape();
 
 		helper.expectTextForClipboard('1');
 	});


More information about the Libreoffice-commits mailing list