[Libreoffice-commits] core.git: libreofficekit/source

Tor Lillqvist (via logerrit) logerrit at kemper.freedesktop.org
Thu Jun 4 12:50:11 UTC 2020


 libreofficekit/source/gtk/lokdocview.cxx |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 716f3e6ff560893febc95f55fc39bc46151afd7f
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Thu Jun 4 15:46:54 2020 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Thu Jun 4 15:49:25 2020 +0300

    Change FIXME to plain comment, there apparently is nothing to do about it here
    
    Change-Id: I81e50e7e604e8ef17ba0d369e8987f4c840f8361

diff --git a/libreofficekit/source/gtk/lokdocview.cxx b/libreofficekit/source/gtk/lokdocview.cxx
index 8bcbd1aeb904..ae2c00bcaa08 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -891,8 +891,9 @@ static gboolean postDocumentLoad(gpointer pData)
 
     std::unique_lock<std::mutex> aGuard(g_aLOKMutex);
     priv->m_pDocument->pClass->initializeForRendering(priv->m_pDocument, priv->m_aRenderingArguments.c_str());
-    // FIXME: This returns the view id of the "current" view, but sadly if you load multiple
-    // documents that is apparently not a view showing the most recently loaded document.
+    // This returns the view id of the "current" view, but sadly if you load multiple documents that
+    // is apparently not a view showing the most recently loaded document. Not much we can do here,
+    // though. If that is fixed, this comment becomes incorrect.
     priv->m_nViewId = priv->m_pDocument->pClass->getView(priv->m_pDocument);
     g_aAuthorViews[getAuthorRenderingArgument(priv)] = priv->m_nViewId;
     priv->m_pDocument->pClass->registerCallback(priv->m_pDocument, callbackWorker, pLOKDocView);


More information about the Libreoffice-commits mailing list