[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Sat Jun 6 17:24:09 UTC 2020


 vcl/source/filter/ipdf/pdfread.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3862929efcc5e9275d878bbe64cb034796e4012d
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Mon Jan 20 13:05:39 2020 +0100
Commit:     Tomaž Vajngerl <quikee at gmail.com>
CommitDate: Sat Jun 6 19:23:36 2020 +0200

    Use properly typed var to iterate over FPDF_GetPageCount
    
    ...which, according to <https://pdfium.patagames.com/help/html/
    M_Patagames_Pdf_Pdfium_FPDF_GetPageCount.htm>, returns int.   The code had oddly
    been like this since it was introduced with
    9194f019afb0599d5e72476786fabfa996e07f20 "pdfium: Import PDF with unloaded
    images."
    
    Change-Id: If8aad3c0bfbecdedea9511cff17e125fb1938f90
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87067
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95617
    Tested-by: Tomaž Vajngerl <quikee at gmail.com>
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>

diff --git a/vcl/source/filter/ipdf/pdfread.cxx b/vcl/source/filter/ipdf/pdfread.cxx
index c5c542a35aad..1d253d023424 100644
--- a/vcl/source/filter/ipdf/pdfread.cxx
+++ b/vcl/source/filter/ipdf/pdfread.cxx
@@ -325,7 +325,7 @@ size_t ImportPDFUnloaded(const OUString& rURL, std::vector<std::pair<Graphic, Si
     // dummy Bitmap
     Bitmap aBitmap(Size(1, 1), 24);
 
-    for (size_t nPageIndex = 0; nPageIndex < static_cast<size_t>(nPageCount); ++nPageIndex)
+    for (int nPageIndex = 0; nPageIndex < nPageCount; ++nPageIndex)
     {
         double fPageWidth = 0;
         double fPageHeight = 0;


More information about the Libreoffice-commits mailing list