[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - include/vcl sd/qa

Tomaž Vajngerl (via logerrit) logerrit at kemper.freedesktop.org
Sat Jun 6 17:26:04 UTC 2020


 include/vcl/vectorgraphicdata.hxx |    2 ++
 sd/qa/unit/data/pdf/multipage.pdf |binary
 sd/qa/unit/import-tests.cxx       |    4 +++-
 3 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 125eda6df4267541177a9b25aa0f1d7c140a49a9
Author:     Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
AuthorDate: Thu Mar 26 12:25:10 2020 +0100
Commit:     Tomaž Vajngerl <quikee at gmail.com>
CommitDate: Sat Jun 6 19:25:31 2020 +0200

    sd: extend test to check the PDF pages aren't rendered when loaded
    
    Change-Id: I9e407bb20a00ec620fe3f772f50708f997027942
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91093
    Tested-by: Jenkins
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>
    (cherry picked from commit 56a1f9bea2f1b64dee4111ec6671caf42ef63c91)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95631
    Tested-by: Tomaž Vajngerl <quikee at gmail.com>

diff --git a/include/vcl/vectorgraphicdata.hxx b/include/vcl/vectorgraphicdata.hxx
index 86b0e6e1ad2f..28828426ac2e 100644
--- a/include/vcl/vectorgraphicdata.hxx
+++ b/include/vcl/vectorgraphicdata.hxx
@@ -111,6 +111,8 @@ public:
     BitmapChecksum GetChecksum() const;
 
     sal_Int32 getPageIndex() const { return mnPageIndex; }
+
+    bool isPrimitiveSequenceCreated() const { return mbSequenceCreated; }
 };
 
 typedef std::shared_ptr< VectorGraphicData > VectorGraphicDataPtr;
diff --git a/sd/qa/unit/data/pdf/multipage.pdf b/sd/qa/unit/data/pdf/multipage.pdf
index 5cd8b4e4e569..65c8eeaa32a5 100644
Binary files a/sd/qa/unit/data/pdf/multipage.pdf and b/sd/qa/unit/data/pdf/multipage.pdf differ
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 006adedcd588..bd719567104c 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -1283,11 +1283,13 @@ void SdImportTest::testPDFImportShared()
 
             const GraphicObject& rGraphicObject = pSdrGrafObj->GetGraphicObject().GetGraphic();
             const Graphic& rGraphic = rGraphicObject.GetGraphic();
+            CPPUNIT_ASSERT_MESSAGE("After loading, the PDF shouldn't have the primitive sequence created yet",
+                                   !rGraphic.getVectorGraphicData()->isPrimitiveSequenceCreated());
             aGraphics.push_back(rGraphic);
         }
     }
 
-    CPPUNIT_ASSERT_EQUAL_MESSAGE("Expected more than one page.", size_t(3), aGraphics.size());
+    CPPUNIT_ASSERT_EQUAL_MESSAGE("Expected more than one page.", size_t(9), aGraphics.size());
 
     Graphic const & rFirstGraphic = aGraphics[0];
 


More information about the Libreoffice-commits mailing list