[Libreoffice-commits] online.git: cypress_test/Makefile.am

Tamás Zolnai (via logerrit) logerrit at kemper.freedesktop.org
Mon Jun 8 22:05:08 UTC 2020


 cypress_test/Makefile.am |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 7da449d23cc1333e03337f93069102cdeac23b45
Author:     Tamás Zolnai <tamas.zolnai at collabora.com>
AuthorDate: Mon Jun 8 20:09:55 2020 +0200
Commit:     Tamás Zolnai <tamas.zolnai at collabora.com>
CommitDate: Tue Jun 9 00:04:50 2020 +0200

    cypress: improve error matcher.
    
    Change-Id: I82f209bfb32660723c1a0ec686b8ba363aa612fc
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/95854
    Tested-by: Jenkins
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>

diff --git a/cypress_test/Makefile.am b/cypress_test/Makefile.am
index 77b270325..23878852a 100644
--- a/cypress_test/Makefile.am
+++ b/cypress_test/Makefile.am
@@ -213,15 +213,17 @@ define run_mobile_tests
 	)
 endef
 
+ERROR_MATCHER = "Error:\|Command failed:\|Timed out retrying"
+
 define execute_run_parallel
 	@mkdir -p $(dir $(2)) && touch $(2) && \
 	echo "`echo $(1) && $(1)`" > $(2) 2>&1 && \
-	if [ -z `grep -o -m 1 "Error:\|Command failed:" $(2)` ];\
+	if [ -z `grep -o -m 1 $(ERROR_MATCHER) $(2)` ];\
 		then cat $(2);\
 		elif [ -z $(CYPRESS_NO_SECOND_CHANCE) ]; \
 		then echo "Second chance!" > $(2) && \
 		     echo "`echo $(1) && $(1)`" >> $(2) 2>&1 && \
-		     if [ -z `grep -o -m 1 "Error:\|Command failed:" $(2)` ];\
+		     if [ -z `grep -o -m 1 $(ERROR_MATCHER) $(2)` ];\
 			then cat $(2);\
 			else cat $(2) >> $(ERROR_LOG) && \
 			     echo -e $(call error_output_string,$(3),$(4)) >> $(ERROR_LOG); \


More information about the Libreoffice-commits mailing list