[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/source

Tor Lillqvist (via logerrit) logerrit at kemper.freedesktop.org
Tue Jun 9 15:21:03 UTC 2020


 sc/source/ui/view/gridwin.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit bdf5f18ebb2c2f3d33e16fa9b9cfef82776fac61
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Tue Jun 9 13:24:59 2020 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Tue Jun 9 17:20:31 2020 +0200

    Prevent soffice.bin from aborting in the autofilter UITest in a debug build
    
    Apparently a superfluous line was added accidentally in
    cd7539be13dee445c643e43547313c57e01f9391, causing a leak of vcl window
    objects.
    
    Without this commit, the Application::Abort() is called from the check
    in Window::dispose() in vcl/source/window/window.cxx.
    
    Change-Id: I358d97ac37e5a86880d5372d553baa6e1e59d7af
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95909
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 4751dcb77b63..ada73c648509 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -638,7 +638,6 @@ void ScGridWindow::LaunchAutoFilterMenu(SCCOL nCol, SCROW nRow)
         // If NWF renders the focus rects itself, that breaks double-buffering.
         mpAutoFilterPopup->RequestDoubleBuffering(true);
 
-    mpAutoFilterPopup.reset(VclPtr<ScCheckListMenuWindow>::Create(this, pDoc));
     if (bLOKActive)
         mpAutoFilterPopup->SetLOKNotifier(SfxViewShell::Current());
     mpAutoFilterPopup->setOKAction(new AutoFilterAction(this, AutoFilterMode::Normal));


More information about the Libreoffice-commits mailing list