[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/view/gridwin.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 3781ef174707fc48ed775306443e5662e35288a6
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Jun 14 18:26:24 2020 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Jun 14 21:10:56 2020 +0200

    tdf#133971 hold self-ref until we return
    
    Change-Id: Iac1b79152c07915675a7dc562aaad9b4c465faa2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96294
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 01783fc98e92..7c318e09cad6 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -298,8 +298,11 @@ IMPL_LINK_NOARG(ScFilterListBox, SelectHdl, weld::TreeView&, bool)
 
 IMPL_LINK_NOARG(ScFilterListBox, AsyncSelectHdl, void*, void)
 {
-    pGridWin->FilterSelect( nSel );
     nAsyncSelectHdl = nullptr;
+
+    //tdf#133971 hold self-ref until we return
+    VclPtr<ScFilterListBox> xThis(this);
+    pGridWin->FilterSelect(nSel);
     if (!pGridWin)
     {
         // tdf#133855 we got disposed by FilterSelect