[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - sw/source

Vasily Melenchuk (via logerrit) logerrit at kemper.freedesktop.org
Wed Jun 24 06:10:37 UTC 2020


 sw/source/core/text/txtfld.cxx |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

New commits:
commit 0453702ea9cf48fc5764bb7d2d6685e0234e09cb
Author:     Vasily Melenchuk <vasily.melenchuk at cib.de>
AuthorDate: Tue Jun 23 08:45:54 2020 +0300
Commit:     Vasily Melenchuk <vasily.melenchuk at cib.de>
CommitDate: Wed Jun 24 08:10:05 2020 +0200

    tdf#83309: sw: do not create bullet with no char
    
    On some machines (depending on fonts installed) creation
    of SwBulletPortion with bullet = \0 leads to drawing
    a bullet as a empty rectangle.
    
    Change-Id: I2826944f2278e8c9a6c740b11b69d2e4e5108158
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96711
    Tested-by: Jenkins
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>
    (cherry picked from commit 5ed96c798679a1613b058a11b30cce4ba0ffd920)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96886
    Reviewed-by: Vasily Melenchuk <vasily.melenchuk at cib.de>

diff --git a/sw/source/core/text/txtfld.cxx b/sw/source/core/text/txtfld.cxx
index 463e7668f4e7..e81ec0e36232 100644
--- a/sw/source/core/text/txtfld.cxx
+++ b/sw/source/core/text/txtfld.cxx
@@ -650,11 +650,14 @@ SwNumberPortion *SwTextFormatter::NewNumberPortion( SwTextFormatInfo &rInf ) con
                 lcl_setRedlineAttr( rInf, *pTextNd, pNumFnt );
 
                 // --> OD 2008-01-23 #newlistelevelattrs#
-                pRet = new SwBulletPortion( rNumFormat.GetBulletChar(),
-                                            pTextNd->GetLabelFollowedBy(),
-                                            std::move(pNumFnt),
-                                            bLeft, bCenter, nMinDist,
-                                            bLabelAlignmentPosAndSpaceModeActive );
+                if (rNumFormat.GetBulletChar())
+                {
+                    pRet = new SwBulletPortion(rNumFormat.GetBulletChar(),
+                        pTextNd->GetLabelFollowedBy(),
+                        std::move(pNumFnt),
+                        bLeft, bCenter, nMinDist,
+                        bLabelAlignmentPosAndSpaceModeActive);
+                }
             }
             else
             {


More information about the Libreoffice-commits mailing list