[Libreoffice-commits] core.git: basic/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Wed Jun 24 14:19:53 UTC 2020


 basic/source/classes/image.cxx |    1 -
 basic/source/comp/parser.cxx   |    1 -
 2 files changed, 2 deletions(-)

New commits:
commit f4c0c3fef7571e8e172c9b27c8b4a390fe72fddd
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Jun 24 14:19:04 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Jun 24 16:19:19 2020 +0200

    Remove no-longer-relevant comments
    
    ...left over by 27239ad23006b1fd1ddb21467f4c1fd637b560d5 "basic: String ->
    OUString",
    
    >                  // Force length 1 and make char 0 afterwards
    > -                String aNullCharStr( rtl::OUString(" ") );
    > -                aNullCharStr.SetChar( 0, 0 );
    > +                OUString aNullCharStr( (sal_Unicode)0);
    >                  return aNullCharStr;
    
    and
    
    >      // Force length 1 and make char 0 afterwards
    > -    String aNullCharStr( rtl::OUString(" ") );
    > -    aNullCharStr.SetChar( 0, 0 );
    > +    OUString aNullCharStr((sal_Unicode)0);
    >      addStringConst( aPublics, "vbNullChar", aNullCharStr );
    
    Change-Id: Icbf69ff7b92374b690cb5c7f0129c6a494db48f1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97031
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/basic/source/classes/image.cxx b/basic/source/classes/image.cxx
index ec4901a549ff..038179334595 100644
--- a/basic/source/classes/image.cxx
+++ b/basic/source/classes/image.cxx
@@ -661,7 +661,6 @@ OUString SbiImage::GetString( short nId ) const
             sal_uInt32 nLen = nNextOff - nOff - 1;
             if( nLen == 1 )
             {
-                // Force length 1 and make char 0 afterwards
                 OUString aNullCharStr( u'\0');
                 return aNullCharStr;
             }
diff --git a/basic/source/comp/parser.cxx b/basic/source/comp/parser.cxx
index d26f4de63fc7..72dc9217f6fc 100644
--- a/basic/source/comp/parser.cxx
+++ b/basic/source/comp/parser.cxx
@@ -857,7 +857,6 @@ void SbiParser::AddConstants()
     addStringConst( aPublics, "vbTab", "\x09" );
     addStringConst( aPublics, "vbVerticalTab", "\x0B" );
 
-    // Force length 1 and make char 0 afterwards
     OUString aNullCharStr(u'\0');
     addStringConst( aPublics, "vbNullChar", aNullCharStr );
 }


More information about the Libreoffice-commits mailing list