[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sc/source

[Tor Lillqvist (via logerrit)]

 sc/source/ui/unoobj/docuno.cxx |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit 818a68cb259078fe2cc1ae1d82d3b854e49b24fe
Author:     Tor Lillqvist <tml at iki.fi>
AuthorDate: Thu Jun 25 15:39:02 2020 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Thu Jun 25 19:55:20 2020 +0200

    Avoid crash with multiple documents open in the iOS app
    
    Also add a FIXME. Just 'hoping' is not good enough. But yeah, much of
    this code indeeed works mostly by accident.
    
    Change-Id: Ic6bcbc10229a0b7cdd8d696794efe152fca4faea
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97117
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Tor Lillqvist <tml at collabora.com>

diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 5cdac44a46ab..e1efd7ca485e 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -505,7 +505,13 @@ void ScModelObj::paintTile( VirtualDevice& rDevice,
 {
     // There seems to be no clear way of getting the grid window for this
     // particular document, hence we need to hope we get the right window.
+    // FIXME: "hope"? Are you kidding me?
     ScViewData* pViewData = ScDocShell::GetViewData();
+
+    // FIXME
+    if (!pViewData)
+        return;
+
     ScGridWindow* pGridWindow = pViewData->GetActiveWin();
 
     // update the size of the area we are painting