[Libreoffice-commits] core.git: sc/source

[Stephan Bergmann (via logerrit)]

 sc/source/core/tool/compiler.cxx |    3 +--
 sc/source/ui/navipi/content.cxx  |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 5cefd8f7877e0fdce16b98d20622e8675641f711
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Jun 26 11:25:09 2020 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Jun 26 12:53:49 2020 +0200

    Upcoming improved loplugin:elidestringvar: sc
    
    Change-Id: Ic53ec0c5ffd661073742151c6c012a1dc1b88f9c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97202
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 0193705b37dd..7a57db4bb4df 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -1901,9 +1901,8 @@ void ScCompiler::CheckTabQuotes( OUString& rString,
         case FormulaGrammar::CONV_ODF :
             if( bNeedsQuote )
             {
-                const OUString one_quote('\'');
                 // escape embedded quotes
-                rString = rString.replaceAll( one_quote, "''" );
+                rString = rString.replaceAll( "'", "''" );
             }
             break;
     }
diff --git a/sc/source/ui/navipi/content.cxx b/sc/source/ui/navipi/content.cxx
index 35d84f760aaf..49d8b62c7fcf 100644
--- a/sc/source/ui/navipi/content.cxx
+++ b/sc/source/ui/navipi/content.cxx
@@ -181,7 +181,7 @@ void ScContentTree::InitRoot( ScContentId nType )
         return;
     }
 
-    OUString aImage(aContentBmps[static_cast<int>(nType) - 1]);
+    auto const aImage(aContentBmps[static_cast<int>(nType) - 1]);
     OUString aName(ScResId(SCSTR_CONTENT_ARY[static_cast<int>(nType)]));
     // back to the correct position:
     sal_uInt16 nPos = nRootType != ScContentId::ROOT ? 0 : pPosList[nType]-1;