[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/data/ods/tdf130583.ods      |binary
 sc/qa/unit/subsequent_filters-test.cxx |   22 ++++++++++++++++++++++
 2 files changed, 22 insertions(+)

New commits:
commit 0960a8c5ce48adb1bc7bd434ed5242b51ce72149
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Fri Jun 26 13:56:18 2020 +0200
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Fri Jun 26 17:27:20 2020 +0200

    tdf#130583: sc: Add unittest
    
    Change-Id: I74f2d90f4f9eb17d1833ceedd1598c1439489354
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97222
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/sc/qa/unit/data/ods/tdf130583.ods b/sc/qa/unit/data/ods/tdf130583.ods
new file mode 100644
index 000000000000..8cfcc97dd196
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf130583.ods differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx
index ca1f0b53a983..f44980c7a146 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -245,6 +245,7 @@ public:
     void testMergedCellsXLSXML();
     void testBackgroundColorStandardXLSXML();
     void testTdf131536();
+    void testTdf130583();
     void testTdf85617();
     void testTdf134234();
     void testNamedExpressionsXLSXML();
@@ -394,6 +395,7 @@ public:
     CPPUNIT_TEST(testMergedCellsXLSXML);
     CPPUNIT_TEST(testBackgroundColorStandardXLSXML);
     CPPUNIT_TEST(testTdf131536);
+    CPPUNIT_TEST(testTdf130583);
     CPPUNIT_TEST(testTdf85617);
     CPPUNIT_TEST(testTdf134234);
     CPPUNIT_TEST(testNamedExpressionsXLSXML);
@@ -3849,6 +3851,26 @@ void ScFiltersTest::testTdf131536()
                                       "=RIGHT(TEXT(INDEX($Comparison.$L:$Z,$Comparison.$A5,$Comparison.D$4),\"0\"),4))", nullptr);
 }
 
+void ScFiltersTest::testTdf130583()
+{
+    ScDocShellRef xDocSh = loadDoc("tdf130583.", FORMAT_ODS);
+    CPPUNIT_ASSERT_MESSAGE("Failed to load the document", xDocSh.is());
+    ScDocument& rDoc = xDocSh->GetDocument();
+
+    CPPUNIT_ASSERT_EQUAL(OUString("b"), rDoc.GetString(ScAddress(1,0,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString("c"), rDoc.GetString(ScAddress(1,1,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString("a"), rDoc.GetString(ScAddress(1,2,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString("d"), rDoc.GetString(ScAddress(1,3,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString("#N/A"), rDoc.GetString(ScAddress(1,4,0)));
+
+    // Without the fix in place, SWITCH would have returned #VALUE!
+    CPPUNIT_ASSERT_EQUAL(OUString("b"), rDoc.GetString(ScAddress(4,0,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString("c"), rDoc.GetString(ScAddress(4,1,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString("a"), rDoc.GetString(ScAddress(4,2,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString("d"), rDoc.GetString(ScAddress(4,3,0)));
+    CPPUNIT_ASSERT_EQUAL(OUString("#N/A"), rDoc.GetString(ScAddress(4,4,0)));
+}
+
 void ScFiltersTest::testTdf85617()
 {
     ScDocShellRef xDocSh = loadDoc("tdf85617.", FORMAT_XLSX);