[Libreoffice-commits] online.git: kit/Kit.cpp

Miklos Vajna (via logerrit) logerrit at kemper.freedesktop.org
Mon Jun 29 07:18:35 UTC 2020


 kit/Kit.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2604913fb64caad2721027fe08dd6bf3012f780f
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Mon Jun 29 09:03:22 2020 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Mon Jun 29 09:18:16 2020 +0200

    kit: mark KitSocketPoll as final
    
    KitSocketPoll has virtual functions, but a non-virtual destructor. Mark
    it as final to make it clear that it's safe to call delete on it.
    
    Change-Id: I685f9d7bcfbb82115e9c25991c877aa99391dd3e
    Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97361
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 269120e60..7a5fc1f7a 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -2158,7 +2158,7 @@ std::shared_ptr<lok::Document> getLOKDocumentForAndroidOnly()
 
 #endif
 
-class KitSocketPoll : public SocketPoll
+class KitSocketPoll final : public SocketPoll
 {
     std::chrono::steady_clock::time_point _pollEnd;
     std::shared_ptr<Document> _document;


More information about the Libreoffice-commits mailing list