[Libreoffice-commits] core.git: compilerplugins/clang framework/inc framework/source vcl/inc vcl/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Mon Jun 29 10:24:25 UTC 2020


 compilerplugins/clang/unusedfields.only-used-in-constructor.results |   44 ++++----
 compilerplugins/clang/unusedfields.readonly.results                 |    2 
 compilerplugins/clang/unusedfields.untouched.results                |   28 +++--
 compilerplugins/clang/unusedfields.writeonly.results                |   54 +++++++---
 framework/inc/uielement/spinfieldtoolbarcontroller.hxx              |    4 
 framework/source/uielement/spinfieldtoolbarcontroller.cxx           |    4 
 vcl/inc/calendar.hxx                                                |    1 
 vcl/source/control/calendar.cxx                                     |    3 
 8 files changed, 86 insertions(+), 54 deletions(-)

New commits:
commit db3b0ddbe0f016268c21eebb0146be87dc738efc
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Jun 29 10:20:12 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Jun 29 12:23:50 2020 +0200

    loplugin:unusedfields
    
    Change-Id: Ia0f517fba3a0660b64c97f426cc2cdfbbcd0ebad
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97391
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index 8e13b041839f..65ba46ffa01d 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -1,5 +1,3 @@
-accessibility/source/extended/textwindowaccessibility.cxx:1019
-      const css::uno::Sequence<css::beans::PropertyValue> &
 avmedia/source/vlc/vlcframegrabber.hxx:35
     avmedia::vlc::VLCFrameGrabber mInstance wrapper::Instance
 avmedia/source/vlc/vlcframegrabber.hxx:36
@@ -86,7 +84,7 @@ cppcanvas/source/mtfrenderer/textaction.cxx:808
     cppcanvas::internal::(anonymous namespace)::EffectTextAction maTextLineInfo const tools::TextLineInfo
 cppcanvas/source/mtfrenderer/textaction.cxx:1641
     cppcanvas::internal::(anonymous namespace)::OutlineAction maTextLineInfo const tools::TextLineInfo
-cppu/source/threadpool/threadpool.cxx:361
+cppu/source/threadpool/threadpool.cxx:365
     _uno_ThreadPool dummy sal_Int32
 cppu/source/typelib/typelib.cxx:60
     (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16
@@ -130,6 +128,14 @@ cppu/source/uno/check.cxx:134
     (anonymous namespace)::Char3 c3 char
 cppu/source/uno/check.cxx:138
     (anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3
+cui/source/dialogs/AdditionsDialog.cxx:53
+    (anonymous namespace)::AdditionInfo sDescription class rtl::OUString
+cui/source/dialogs/AdditionsDialog.cxx:55
+    (anonymous namespace)::AdditionInfo sReleaseVersion class rtl::OUString
+cui/source/dialogs/AdditionsDialog.cxx:59
+    (anonymous namespace)::AdditionInfo sRating class rtl::OUString
+cui/source/dialogs/AdditionsDialog.cxx:61
+    (anonymous namespace)::AdditionInfo sDownloadURL class rtl::OUString
 cui/source/dialogs/colorpicker.cxx:737
     cui::(anonymous namespace)::ColorPickerDialog m_aColorPrevious class cui::(anonymous namespace)::ColorPreviewControl
 cui/source/factory/dlgfact.cxx:1408
@@ -140,8 +146,6 @@ cui/source/inc/cuitabarea.hxx:224
     SvxAreaTabPage maFixed_ChangeType enum ChangeType
 cui/source/inc/cuitabarea.hxx:232
     SvxAreaTabPage m_aXFillAttr class XFillAttrSetItem
-cui/source/inc/passwdomdlg.hxx:45
-    PasswordToOpenModifyDialog m_aIndicatorTemplate class rtl::OUString
 cui/source/inc/tabstpge.hxx:85
     SvxTabulatorTabPage m_aLeftWin class TabWin_Impl
 cui/source/inc/tabstpge.hxx:86
@@ -276,14 +280,14 @@ include/sfx2/msg.hxx:138
     SfxType7 nAttribs sal_uInt16
 include/sfx2/msg.hxx:138
     SfxType7 aAttrib struct SfxTypeAttrib [7]
-include/sfx2/msg.hxx:139
-    SfxType8 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:139
     SfxType8 aAttrib struct SfxTypeAttrib [8]
 include/sfx2/msg.hxx:139
     SfxType8 pType const std::type_info *
 include/sfx2/msg.hxx:139
     SfxType8 nAttribs sal_uInt16
+include/sfx2/msg.hxx:139
+    SfxType8 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:140
     SfxType10 pType const std::type_info *
 include/sfx2/msg.hxx:140
@@ -328,10 +332,10 @@ include/sfx2/msg.hxx:146
     SfxType17 pType const std::type_info *
 include/sfx2/msg.hxx:146
     SfxType17 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
-include/sfx2/msg.hxx:146
-    SfxType17 nAttribs sal_uInt16
 include/sfx2/msg.hxx:146
     SfxType17 aAttrib struct SfxTypeAttrib [17]
+include/sfx2/msg.hxx:146
+    SfxType17 nAttribs sal_uInt16
 include/sfx2/msg.hxx:147
     SfxType23 nAttribs sal_uInt16
 include/sfx2/msg.hxx:147
@@ -532,12 +536,10 @@ sc/source/filter/xml/xmlexternaltabi.hxx:111
     ScXMLExternalRefCellContext mnCellType sal_Int16
 sc/source/filter/xml/xmltransformationi.hxx:155
     ScXMLDateTimeContext aType class rtl::OUString
+sc/source/ui/docshell/docfunc.cxx:1550
+      const class ScDPCollection *&
 sc/source/ui/inc/acredlin.hxx:50
     ScAcceptChgDlg aReOpenIdle class Idle
-sc/source/ui/inc/checklistmenu.hxx:285
-    ScCheckListMenuControl mnWidthHint int
-sc/source/ui/inc/checklistmenu.hxx:288
-    ScCheckListMenuControl maMenuSize class Size
 sc/source/ui/inc/msgpool.hxx:35
     ScMessagePool aGlobalStringItem class SfxStringItem
 sc/source/ui/inc/msgpool.hxx:36
@@ -596,10 +598,10 @@ sd/source/ui/view/viewshel.cxx:1165
     sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
 sd/source/ui/view/viewshel.cxx:1166
     sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context
-sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
-    (anonymous namespace)::PDFGrammar::definition boolean rule<ScannerT>
 sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
     (anonymous namespace)::PDFGrammar::definition simple_type rule<ScannerT>
+sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
+    (anonymous namespace)::PDFGrammar::definition boolean rule<ScannerT>
 sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
     (anonymous namespace)::PDFGrammar::definition name rule<ScannerT>
 sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
@@ -736,7 +738,7 @@ sw/inc/unosett.hxx:145
     SwXNumberingRules m_pImpl ::sw::UnoImplPtr<Impl>
 sw/qa/core/test_ToxTextGenerator.cxx:140
     (anonymous namespace)::ToxTextGeneratorWithMockedChapterField mChapterFieldType class SwChapterFieldType
-sw/qa/extras/uiwriter/uiwriter.cxx:4220
+sw/qa/extras/uiwriter/uiwriter.cxx:4222
     (anonymous namespace)::IdleTask maIdle class Idle
 sw/source/core/crsr/crbm.cxx:64
     (anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState
@@ -768,6 +770,8 @@ sw/source/uibase/inc/uivwimp.hxx:93
     SwView_Impl xTmpSelDocSh class SfxObjectShellLock
 sw/source/uibase/inc/unodispatch.hxx:45
     SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard class SolarMutexGuard
+sw/source/uibase/sidebar/WriterInspectorTextPanel.hxx:51
+    sw::sidebar::WriterInspectorTextPanel maCharStyle sfx2::sidebar::ControllerItem
 toolkit/source/awt/stylesettings.cxx:94
     toolkit::(anonymous namespace)::StyleMethodGuard m_aGuard class SolarMutexGuard
 ucb/source/ucp/gio/gio_mount.hxx:74
@@ -800,9 +804,9 @@ vcl/inc/salmenu.hxx:43
     SalMenuButtonItem maImage class Image
 vcl/inc/salmenu.hxx:44
     SalMenuButtonItem maToolTipText class rtl::OUString
-vcl/inc/salvtables.hxx:562
+vcl/inc/salvtables.hxx:561
     SalInstanceEntry m_aTextFilter class WeldTextFilter
-vcl/inc/salvtables.hxx:936
+vcl/inc/salvtables.hxx:935
     SalInstanceComboBoxWithEdit m_aTextFilter class WeldTextFilter
 vcl/inc/svimpbox.hxx:127
     SvImpLBox m_aFctSet class ImpLBSelEng
@@ -858,9 +862,9 @@ vcl/unx/gtk3/gtk3gtkinst.cxx:5294
     (anonymous namespace)::CustomCellRendererSurface parent GtkCellRendererText
 vcl/unx/gtk3/gtk3gtkinst.cxx:5302
     (anonymous namespace)::CustomCellRendererSurfaceClass parent_class GtkCellRendererTextClass
-vcl/unx/gtk3/gtk3gtkinst.cxx:12849
+vcl/unx/gtk3/gtk3gtkinst.cxx:12866
     (anonymous namespace)::GtkInstanceComboBox m_pOverlay GtkOverlay *
-vcl/unx/gtk3/gtk3gtkinst.cxx:12855
+vcl/unx/gtk3/gtk3gtkinst.cxx:12872
     (anonymous namespace)::GtkInstanceComboBox m_pMenuTextRenderer GtkCellRenderer *
 writerfilter/source/dmapper/PropertyMap.hxx:220
     writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results
index bcdad96dcdb0..333d6b4385ae 100644
--- a/compilerplugins/clang/unusedfields.readonly.results
+++ b/compilerplugins/clang/unusedfields.readonly.results
@@ -926,7 +926,7 @@ vcl/source/app/settings.cxx:196
     ImplStyleData maDialogStyle struct DialogStyle
 vcl/source/control/roadmapwizard.cxx:63
     vcl::RoadmapWizardImpl aStateDescriptors vcl::(anonymous namespace)::StateDescriptions
-vcl/source/control/tabctrl.cxx:79
+vcl/source/control/tabctrl.cxx:80
     ImplTabCtrlData maLayoutPageIdToLine std::unordered_map<int, int>
 vcl/source/filter/jpeg/Exif.hxx:53
     Exif::ExifIFD tag sal_uInt8 [2]
diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index e878bc0cf510..e59e3599567c 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -1,5 +1,3 @@
-accessibility/source/extended/textwindowaccessibility.cxx:1019
-      const css::uno::Sequence<css::beans::PropertyValue> &
 avmedia/source/vlc/wrapper/Types.hxx:38
     libvlc_event_t p_obj void *
 avmedia/source/vlc/wrapper/Types.hxx:43
@@ -34,10 +32,18 @@ connectivity/source/drivers/evoab2/NStatement.hxx:57
     connectivity::evoab::FieldSort bAscending _Bool
 connectivity/source/drivers/mork/MDatabaseMetaData.hxx:30
     connectivity::mork::ODatabaseMetaData m_pMetaDataHelper std::unique_ptr<MDatabaseMetaDataHelper>
-cppu/source/threadpool/threadpool.cxx:361
+cppu/source/threadpool/threadpool.cxx:365
     _uno_ThreadPool dummy sal_Int32
 cppu/source/typelib/typelib.cxx:60
     (anonymous namespace)::AlignSize_Impl nInt16 sal_Int16
+cui/source/dialogs/AdditionsDialog.cxx:53
+    (anonymous namespace)::AdditionInfo sDescription class rtl::OUString
+cui/source/dialogs/AdditionsDialog.cxx:55
+    (anonymous namespace)::AdditionInfo sReleaseVersion class rtl::OUString
+cui/source/dialogs/AdditionsDialog.cxx:59
+    (anonymous namespace)::AdditionInfo sRating class rtl::OUString
+cui/source/dialogs/AdditionsDialog.cxx:61
+    (anonymous namespace)::AdditionInfo sDownloadURL class rtl::OUString
 dbaccess/source/core/inc/databasecontext.hxx:85
     dbaccess::ODatabaseContext m_aBasicDLL class BasicDLL
 dbaccess/source/sdbtools/inc/connectiondependent.hxx:115
@@ -76,12 +82,12 @@ include/sfx2/msg.hxx:132
     SfxType1 aAttrib struct SfxTypeAttrib [1]
 include/sfx2/msg.hxx:133
     SfxType2 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
-include/sfx2/msg.hxx:133
-    SfxType2 nAttribs sal_uInt16
 include/sfx2/msg.hxx:133
     SfxType2 pType const std::type_info *
 include/sfx2/msg.hxx:133
     SfxType2 aAttrib struct SfxTypeAttrib [2]
+include/sfx2/msg.hxx:133
+    SfxType2 nAttribs sal_uInt16
 include/sfx2/msg.hxx:134
     SfxType3 pType const std::type_info *
 include/sfx2/msg.hxx:134
@@ -108,12 +114,12 @@ include/sfx2/msg.hxx:136
     SfxType5 pType const std::type_info *
 include/sfx2/msg.hxx:137
     SfxType6 nAttribs sal_uInt16
+include/sfx2/msg.hxx:137
+    SfxType6 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:137
     SfxType6 aAttrib struct SfxTypeAttrib [6]
 include/sfx2/msg.hxx:137
     SfxType6 pType const std::type_info *
-include/sfx2/msg.hxx:137
-    SfxType6 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:138
     SfxType7 nAttribs sal_uInt16
 include/sfx2/msg.hxx:138
@@ -316,8 +322,8 @@ sc/source/filter/html/htmlpars.cxx:3018
     (anonymous namespace)::CSSHandler::MemStr mn size_t
 sc/source/filter/inc/sheetdatacontext.hxx:52
     oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
-sc/source/ui/inc/checklistmenu.hxx:288
-    ScCheckListMenuControl maMenuSize class Size
+sc/source/ui/docshell/docfunc.cxx:1550
+      const class ScDPCollection *&
 sc/source/ui/inc/docsh.hxx:453
     ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
 sc/source/ui/inc/PivotLayoutTreeListBase.hxx:48
@@ -382,7 +388,7 @@ svx/source/dialog/weldeditview.cxx:312
     (anonymous namespace)::WeldEditSource m_rEditAcc class WeldEditAccessible &
 svx/source/inc/datanavi.hxx:189
     svxform::XFormsPage m_aDropHelper class svxform::DataTreeDropTarget
-svx/source/inc/svdpdf.hxx:105
+svx/source/inc/svdpdf.hxx:104
     ImpSdrPdfImport mpPDFium std::shared_ptr<vcl::pdf::PDFium>
 svx/source/tbxctrls/layctrl.cxx:434
     (anonymous namespace)::ColumnsWindow mxControl rtl::Reference<SvxColumnsToolBoxControl>
@@ -402,6 +408,8 @@ sw/source/uibase/inc/uivwimp.hxx:93
     SwView_Impl xTmpSelDocSh class SfxObjectShellLock
 sw/source/uibase/inc/unodispatch.hxx:45
     SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard class SolarMutexGuard
+sw/source/uibase/sidebar/WriterInspectorTextPanel.hxx:51
+    sw::sidebar::WriterInspectorTextPanel maCharStyle sfx2::sidebar::ControllerItem
 toolkit/source/awt/stylesettings.cxx:94
     toolkit::(anonymous namespace)::StyleMethodGuard m_aGuard class SolarMutexGuard
 unoidl/source/unoidlprovider.cxx:672
diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results
index 2c4d99872c0a..7c35c7102ec1 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -116,6 +116,40 @@ configmgr/source/components.cxx:162
     configmgr::Components::WriteThread reference_ rtl::Reference<WriteThread> *
 connectivity/source/drivers/mork/MorkParser.hxx:132
     MorkParser error_ enum MorkErrors
+connectivity/source/drivers/postgresql/pq_statics.hxx:105
+    pq_sdbc_driver::ImplementationStatics types css::uno::Sequence<css::uno::Type>
+connectivity/source/drivers/postgresql/pq_statics.hxx:145
+    pq_sdbc_driver::Statics NO_NULLS class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:146
+    pq_sdbc_driver::Statics NULABLE class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:147
+    pq_sdbc_driver::Statics NULLABLE_UNKNOWN class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:148
+    pq_sdbc_driver::Statics SELECT class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:149
+    pq_sdbc_driver::Statics UPDATE class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:150
+    pq_sdbc_driver::Statics INSERT class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:151
+    pq_sdbc_driver::Statics DELETE class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:152
+    pq_sdbc_driver::Statics RULE class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:153
+    pq_sdbc_driver::Statics REFERENCES class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:154
+    pq_sdbc_driver::Statics TRIGGER class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:155
+    pq_sdbc_driver::Statics EXECUTE class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:156
+    pq_sdbc_driver::Statics USAGE class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:157
+    pq_sdbc_driver::Statics CREATE class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:158
+    pq_sdbc_driver::Statics TEMPORARY class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:191
+    pq_sdbc_driver::Statics KEY_COLUMN class rtl::OUString
+connectivity/source/drivers/postgresql/pq_statics.hxx:215
+    pq_sdbc_driver::Statics HELP_TEXT class rtl::OUString
 connectivity/source/inc/calc/CConnection.hxx:52
     connectivity::calc::OCalcConnection::CloseVetoButTerminateListener m_pCloseListener std::unique_ptr<utl::CloseVeto>
 connectivity/source/inc/odbc/OConnection.hxx:55
@@ -284,6 +318,10 @@ framework/inc/uielement/langselectionmenucontroller.hxx:77
     framework::LanguageSelectionMenuController m_xMenuDispatch_Font css::uno::Reference<css::frame::XDispatch>
 framework/inc/uielement/langselectionmenucontroller.hxx:79
     framework::LanguageSelectionMenuController m_xMenuDispatch_CharDlgForParagraph css::uno::Reference<css::frame::XDispatch>
+framework/inc/uielement/spinfieldtoolbarcontroller.hxx:64
+    framework::SpinfieldToolbarController m_bMaxSet _Bool
+framework/inc/uielement/spinfieldtoolbarcontroller.hxx:65
+    framework::SpinfieldToolbarController m_bMinSet _Bool
 framework/source/layoutmanager/toolbarlayoutmanager.hxx:272
     framework::ToolbarLayoutManager m_pGlobalSettings std::unique_ptr<GlobalSettings>
 framework/source/layoutmanager/toolbarlayoutmanager.hxx:276
@@ -414,8 +452,6 @@ include/vcl/sysdata.hxx:69
     SystemEnvData pSalFrame void *
 include/vcl/textrectinfo.hxx:32
     TextRectInfo mnLineCount sal_uInt16
-include/vcl/toolkit/lstbox.hxx:91
-    ListBox mnSaveValue sal_Int32
 include/vcl/vclenum.hxx:202
     ItalicMatrix yy double
 include/vcl/vclenum.hxx:202
@@ -560,10 +596,6 @@ sc/source/filter/xml/xmlexternaltabi.hxx:111
     ScXMLExternalRefCellContext mnCellType sal_Int16
 sc/source/ui/inc/AccessibleText.hxx:194
     ScAccessiblePreviewHeaderCellTextData mbRowHeader _Bool
-sc/source/ui/inc/checklistmenu.hxx:91
-    ScCheckListMenuControl::MenuItemData maText class rtl::OUString
-sc/source/ui/inc/checklistmenu.hxx:93
-    ScCheckListMenuControl::MenuItemData mbSeparator _Bool
 sc/source/ui/inc/datastream.hxx:105
     sc::DataStream mnSettings sal_uInt32
 sc/source/ui/inc/drawview.hxx:42
@@ -760,10 +792,6 @@ svx/source/inc/docrecovery.hxx:131
     svx::DocRecovery::TURLInfo Module class rtl::OUString
 svx/source/inc/StylesPreviewToolBoxControl.hxx:34
     StylesPreviewToolBoxControl m_xWeldBox std::unique_ptr<StylesPreviewWindow_Base>
-svx/source/inc/StylesPreviewToolBoxControl.hxx:35
-    StylesPreviewToolBoxControl m_pBox class StylesPreviewWindow_Base *
-svx/source/inc/svdpdf.hxx:93
-    ImpSdrPdfImport mdPageWidthPts double
 svx/source/sdr/attribute/sdrformtextattribute.cxx:153
     drawinglayer::attribute::ImpSdrFormTextAttribute mnFormTextShdwTransp sal_uInt16
 svx/source/sdr/attribute/sdrtextattribute.cxx:49
@@ -986,6 +1014,8 @@ vbahelper/source/vbahelper/vbafillformat.hxx:36
     ScVbaFillFormat m_nForeColor sal_Int32
 vcl/inc/accel.h:33
     ImplAccelEntry mpAutoAccel class Accelerator *
+vcl/inc/calendar.hxx:159
+    Calendar mbTravelSelect _Bool
 vcl/inc/driverblocklist.hxx:99
     DriverBlocklist::DriverInfo maMsg class rtl::OUString
 vcl/inc/fontselect.hxx:61
@@ -1104,7 +1134,7 @@ vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
 vcl/unx/gtk3/gtk3gtkinst.cxx:1613
      in char *
-vcl/unx/gtk3/gtk3gtkinst.cxx:12859
+vcl/unx/gtk3/gtk3gtkinst.cxx:12876
     (anonymous namespace)::GtkInstanceComboBox m_xCustomMenuButtonHelper std::unique_ptr<CustomRenderMenuButtonHelper>
 vcl/unx/gtk3/gtk3hudawareness.cxx:18
     (anonymous namespace)::HudAwarenessHandle connection GDBusConnection *
@@ -1116,7 +1146,7 @@ writerfilter/source/dmapper/DomainMapperTableHandler.cxx:234
     writerfilter::dmapper::TableInfo aTablePropertyIds std::vector<PropertyIds>
 writerfilter/source/dmapper/PropertyMap.hxx:220
     writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
-writerfilter/source/dmapper/SettingsTable.cxx:263
+writerfilter/source/dmapper/SettingsTable.cxx:264
     writerfilter::dmapper::SettingsTable_Impl m_sRedlineProtectionKey class rtl::OUString
 xmlhelp/source/cxxhelp/provider/databases.hxx:251
     chelp::Databases m_aDatabases chelp::Databases::DatabasesTable
diff --git a/framework/inc/uielement/spinfieldtoolbarcontroller.hxx b/framework/inc/uielement/spinfieldtoolbarcontroller.hxx
index 8085c68c1cbf..beb95049a206 100644
--- a/framework/inc/uielement/spinfieldtoolbarcontroller.hxx
+++ b/framework/inc/uielement/spinfieldtoolbarcontroller.hxx
@@ -60,9 +60,7 @@ class SpinfieldToolbarController final : public ComplexToolbarController
 
         bool impl_getValue( const css::uno::Any& rAny, sal_Int32& nValue, double& fValue, bool& bFloat );
 
-        bool              m_bFloat,
-                          m_bMaxSet,
-                          m_bMinSet;
+        bool              m_bFloat;
         double            m_nMax;
         double            m_nMin;
         double            m_nValue;
diff --git a/framework/source/uielement/spinfieldtoolbarcontroller.cxx b/framework/source/uielement/spinfieldtoolbarcontroller.cxx
index 6747b21ece89..04de7c1a7db5 100644
--- a/framework/source/uielement/spinfieldtoolbarcontroller.cxx
+++ b/framework/source/uielement/spinfieldtoolbarcontroller.cxx
@@ -199,8 +199,6 @@ SpinfieldToolbarController::SpinfieldToolbarController(
     const OUString&                          aCommand ) :
     ComplexToolbarController( rxContext, rFrame, pToolbar, nID, aCommand )
     ,   m_bFloat( false )
-    ,   m_bMaxSet( false )
-    ,   m_bMinSet( false )
     ,   m_nMax( 0.0 )
     ,   m_nMin( 0.0 )
     ,   m_nValue( 0.0 )
@@ -402,13 +400,11 @@ void SpinfieldToolbarController::executeControlCommand( const css::frame::Contro
     {
         m_nMax = aMax.toDouble();
         m_pSpinfieldControl->set_max(m_nMax);
-        m_bMaxSet = true;
     }
     if ( !aMin.isEmpty() )
     {
         m_nMin = aMin.toDouble();
         m_pSpinfieldControl->set_min(m_nMin);
-        m_bMinSet = true;
     }
     if ( !aStep.isEmpty() )
     {
diff --git a/vcl/inc/calendar.hxx b/vcl/inc/calendar.hxx
index 22cc1ddc9fd2..de209dea5f8c 100644
--- a/vcl/inc/calendar.hxx
+++ b/vcl/inc/calendar.hxx
@@ -156,7 +156,6 @@ class Calendar final : public Control
                     mbSpinDown:1,
                     mbPrevIn:1,
                     mbNextIn:1,
-                    mbTravelSelect:1,
                     mbAllSel:1;
     Link<Calendar*,void>   maSelectHdl;
     Link<Calendar*,void>   maActivateHdl;
diff --git a/vcl/source/control/calendar.cxx b/vcl/source/control/calendar.cxx
index d8d3d1f88c01..bc6653b95181 100644
--- a/vcl/source/control/calendar.cxx
+++ b/vcl/source/control/calendar.cxx
@@ -79,7 +79,6 @@ void Calendar::ImplInit( WinBits nWinStyle )
     mbSpinDown              = false;
     mbPrevIn                = false;
     mbNextIn                = false;
-    mbTravelSelect          = false;
     mbAllSel                = false;
 
     OUString aGregorian( "gregorian");
@@ -1134,9 +1133,7 @@ void Calendar::KeyInput( const KeyEvent& rKEvt )
     if ( aNewDate != maCurDate )
     {
         SetCurDate( aNewDate );
-        mbTravelSelect = true;
         Select();
-        mbTravelSelect = false;
     }
 
     if (rKEvt.GetKeyCode().GetCode() == KEY_RETURN)


More information about the Libreoffice-commits mailing list