[Libreoffice-commits] core.git: bin/check-missing-unittests.py

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Tue Jun 30 15:14:44 UTC 2020


 bin/check-missing-unittests.py |   44 ++++++++++++++++++++++++++++-------------
 1 file changed, 31 insertions(+), 13 deletions(-)

New commits:
commit af5c748b39d0436b5f3c943ba357cf9e75aa0144
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Tue Jun 16 10:41:09 2020 +0200
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Tue Jun 30 17:14:06 2020 +0200

    check-missing-unittests: Add date to the output and...
    
    check for writer undo and calc interpreter missing tests
    
    Change-Id: Ic891f3585eb96eda3c9c6ab4d012cd03d324df54
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96436
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofauli at libreoffice.org>

diff --git a/bin/check-missing-unittests.py b/bin/check-missing-unittests.py
index 9a81b3ab71a9..cab6509fda93 100755
--- a/bin/check-missing-unittests.py
+++ b/bin/check-missing-unittests.py
@@ -20,7 +20,14 @@ def main(ignoredBugs):
             'xlsx': {},
             'xhtml': {},
             'html': {},
-        }
+        },
+        'undo': {
+            'writer': {}
+        },
+        'import': {
+            'calc': {}
+        },
+
     }
     hasTestSet = set()
 
@@ -32,13 +39,15 @@ def main(ignoredBugs):
             ['git', '-C', repoPath, 'rev-parse', 'HEAD'],
             stderr=subprocess.DEVNULL)
     output = subprocess.check_output(
-            ['git', '-C', repoPath, 'log', '--since="2012-01-01', '--name-only' ,'--pretty=format:"%s"'],
+            ['git', '-C', repoPath, 'log', '--since="2012-01-01', '--name-only' ,'--pretty=format:"%s%n%ad"', '--date=format:"%Y/%m/%d"'],
             stderr=subprocess.DEVNULL)
     commits = output.decode('utf-8', 'ignore').split('\n\n')
 
     for commit in reversed(commits):
 
-        summary = commit.split('\n', 1)[0].lower()
+        commitInfo = commit.split('\n')
+
+        summary = commitInfo[0].strip('"').lower()
 
         #Check summary has a bug id
         if 'tdf#' in summary or 'fdo#' in summary:
@@ -63,7 +72,10 @@ def main(ignoredBugs):
             if bugId in hasTestSet:
                 continue
 
-            changedFiles = commit.split('\n', 1)[1]
+            date = commitInfo[1].strip('"')
+            infoList = [date, summary]
+
+            changedFiles = "".join(commitInfo[2:])
             if 'qa' in changedFiles:
                 hasTestSet.add(bugId)
                 continue
@@ -71,22 +83,28 @@ def main(ignoredBugs):
             elif 'sw/source/filter/ww8/docx' in changedFiles or \
                     'writerfilter/source/dmapper' in changedFiles or \
                     'starmath/source/ooxmlimport' in changedFiles:
-                results['export']['docx'][bugId] = summary
+                results['export']['docx'][bugId] = infoList
 
             elif 'sw/source/filter/ww8/ww8' in changedFiles:
-                results['export']['doc'][bugId] = summary
+                results['export']['doc'][bugId] = infoList
 
             elif 'sc/source/filter/excel/xe' in changedFiles:
-                results['export']['xlsx'][bugId] = summary
+                results['export']['xlsx'][bugId] = infoList
 
             elif 'oox/source/export/' in changedFiles:
-                results['export']['pptx'][bugId] = summary
+                results['export']['pptx'][bugId] = infoList
 
             elif 'filter/source/xslt/odf2xhtml/export' in changedFiles:
-                results['export']['xhtml'][bugId] = summary
+                results['export']['xhtml'][bugId] = infoList
 
             elif 'sw/source/filter/html/' in changedFiles:
-                results['export']['html'][bugId] = summary
+                results['export']['html'][bugId] = infoList
+
+            elif 'sw/source/core/undo/' in changedFiles:
+                results['undo']['writer'][bugId] = infoList
+
+            elif 'sc/source/core/tool/interpr' in changedFiles:
+                results['import']['calc'][bugId] = infoList
 
             # Add others here
 
@@ -106,11 +124,11 @@ def main(ignoredBugs):
         print('\n== ' + k + ' ==')
         for k1, v1 in v.items():
             print('\n=== ' + k1 + ' ===')
-            for bugId, summary in v1.items():
+            for bugId, info in v1.items():
                 if bugId not in hasTestSet:
                     print(
-                        "* {} - [https://bugs.documentfoundation.org/show_bug.cgi?id={} tdf#{}]".format(
-                        summary, bugId, bugId))
+                        "# {} - {} - [https://bugs.documentfoundation.org/show_bug.cgi?id={} tdf#{}]".format(
+                        info[0], info[1], bugId, bugId))
     print('\n== ignored bugs ==')
     print(' '.join(ignoredBugs))
     print()


More information about the Libreoffice-commits mailing list