[Libreoffice-commits] core.git: logerrit

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Mon Mar 2 12:17:42 UTC 2020


 logerrit |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6ad2ec4e98157618a9ff5b9097d84b45d16c7038
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Mar 2 11:39:00 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Mar 2 13:17:08 2020 +0100

    fix get_SHA_for_change in logerrit script
    
    after
        commit 02b5d09c0dab1621ce23f9a8df45fa1628be3ece
        tdf#105204 fix shellcheck warnings in logerrit
    the previous get_SHA_for_change returned a URL with a leading space,
    which was previously implicitly stripped. Adding quotes prevents that
    stripping, so we need to explicitly strip here
    
    Change-Id: I5b303f6ca5b1dc7d2a369afc2c52830b1b9586eb
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89816
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/logerrit b/logerrit
index 136f0fb3945c..86f39cef99ab 100755
--- a/logerrit
+++ b/logerrit
@@ -5,7 +5,7 @@ GERRITHOST=logerrit
 GERRITURL="ssh://$GERRITHOST/core"
 
 get_SHA_for_change() {
-    SHA=$(ssh "${GERRITHOST?}" gerrit query --all-approvals change:"$1"|grep ref|tail -1|cut -d: -f2)
+    SHA=$(ssh "${GERRITHOST?}" gerrit query --all-approvals change:"$1" | grep ref | tail -1 | cut -d: -f2 | sed 's/^ *//')
 }
 
 submit() {


More information about the Libreoffice-commits mailing list