[Libreoffice-commits] core.git: connectivity/source
Julien Nabet (via logerrit)
logerrit at kemper.freedesktop.org
Sun Mar 8 15:35:38 UTC 2020
connectivity/source/drivers/firebird/DatabaseMetaData.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit bb51f81507a405266d251297684bd3ab60998197
Author: Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sun Mar 8 13:58:35 2020 +0100
Commit: Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sun Mar 8 16:34:59 2020 +0100
tdf#131217: position arg in Blob::getBytes begins at 1 not 0 (Firebird)
See part of bt here:
https://bugs.documentfoundation.org/show_bug.cgi?id=131217#c5
According to:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=38ce989b4f9d2aead097e5a2e95b819def7e2624
position can't be 0
Change-Id: Ia7bf973b820b8642b45eb0bbc125011cab99de9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90186
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
index 3fb6435f60be..32e397041d89 100644
--- a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
+++ b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
@@ -1248,7 +1248,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getColumns(
if (xDescriptionBlob.is())
{
sal_Int32 aBlobLength = static_cast<sal_Int32>(xDescriptionBlob->length());
- aDescription = OUString(reinterpret_cast<char*>(xDescriptionBlob->getBytes(0, aBlobLength).getArray()),
+ aDescription = OUString(reinterpret_cast<char*>(xDescriptionBlob->getBytes(1, aBlobLength).getArray()),
aBlobLength,
RTL_TEXTENCODING_UTF8);
}
@@ -1415,7 +1415,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTables(
// TODO: we should actually be using CLOB here instead.
// However we haven't implemented CLOB yet, so use BLOB.
sal_Int32 aBlobLength = static_cast<sal_Int32>(xBlob->length());
- sDescription = OUString(reinterpret_cast<char*>(xBlob->getBytes(0, aBlobLength).getArray()),
+ sDescription = OUString(reinterpret_cast<char*>(xBlob->getBytes(1, aBlobLength).getArray()),
aBlobLength,
RTL_TEXTENCODING_UTF8);
}
More information about the Libreoffice-commits
mailing list