[Libreoffice-commits] core.git: xmloff/source

[Noel Grandin (via logerrit)]

 xmloff/source/draw/ximppage.cxx |   10 ----------
 xmloff/source/draw/ximppage.hxx |    2 --
 2 files changed, 12 deletions(-)

New commits:
commit fca333820d24b0c4542e2f8e190da7a56dd55456
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Mar 9 13:00:40 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Mar 9 14:45:48 2020 +0100

    StartElement/EndElement in SdXMLGenericPageContext are superfluous now
    
    after
        commit 2176aed0e3a79bd457ad3678490262dae9ea1361 (HEAD -> master)
        Date:   Mon Mar 9 10:09:48 2020 +0200
        convert SdXMLGenericPageContext to fastparser
    
    Change-Id: I5b1b8dff1a667e4e916b6625a1fca2d0a6b9b9c2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90216
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/xmloff/source/draw/ximppage.cxx b/xmloff/source/draw/ximppage.cxx
index e3cd009a4139..1c3c555b719d 100644
--- a/xmloff/source/draw/ximppage.cxx
+++ b/xmloff/source/draw/ximppage.cxx
@@ -231,11 +231,6 @@ SdXMLGenericPageContext::~SdXMLGenericPageContext()
 {
 }
 
-void SdXMLGenericPageContext::StartElement( const Reference< css::xml::sax::XAttributeList >& )
-{
-    assert(false);
-}
-
 void SdXMLGenericPageContext::startFastElement( sal_Int32 /*nElement*/, const Reference< css::xml::sax::XFastAttributeList >& )
 {
     GetImport().GetShapeImport()->pushGroupForPostProcessing( mxShapes );
@@ -281,11 +276,6 @@ SvXMLImportContextRef SdXMLGenericPageContext::CreateChildContext( sal_uInt16 nP
     return xContext;
 }
 
-void SdXMLGenericPageContext::EndElement()
-{
-    assert(false);
-}
-
 void SdXMLGenericPageContext::endFastElement(sal_Int32 )
 {
     GetImport().GetShapeImport()->popGroupAndPostProcess();
diff --git a/xmloff/source/draw/ximppage.hxx b/xmloff/source/draw/ximppage.hxx
index ba2eef58b8f4..daa47f9ec48a 100644
--- a/xmloff/source/draw/ximppage.hxx
+++ b/xmloff/source/draw/ximppage.hxx
@@ -64,14 +64,12 @@ public:
         css::uno::Reference< css::drawing::XShapes > const & rShapes);
     virtual ~SdXMLGenericPageContext() override;
 
-    virtual void StartElement( const css::uno::Reference< css::xml::sax::XAttributeList >& xAttrList ) final  override;
     virtual void SAL_CALL startFastElement( sal_Int32 nElement, const css::uno::Reference< css::xml::sax::XFastAttributeList >& xAttrList ) override;
     virtual SvXMLImportContextRef CreateChildContext(
         sal_uInt16 nPrefix, const OUString& rLocalName,
         const css::uno::Reference< css::xml::sax::XAttributeList>& xAttrList ) override;
     virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL createFastChildContext(
         sal_Int32 nElement, const css::uno::Reference< css::xml::sax::XFastAttributeList >& AttrList ) override;
-    virtual void EndElement() final override;
     virtual void SAL_CALL endFastElement(sal_Int32 nElement) override;
 
     const css::uno::Reference< css::drawing::XShapes >& GetLocalShapesContext() const