[Libreoffice-commits] core.git: vcl/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Wed Mar 11 15:49:33 UTC 2020


 vcl/source/treelist/svimpbox.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d6717f243fe4a4935c96da791799d9c62fc8f84f
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Mar 11 14:16:20 2020 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Mar 11 16:48:58 2020 +0100

    Window::Update means to call Paint immediately
    
    rather than wait until the next event loop. This is causing the scrollbar to be
    painted at pos 0 and then appears to flicker when it is repainted at its final
    position when the gen navigator treeview is cleared and refilled.
    
    call Invalidate instead to schedule in the painting of the scrollbars at the
    usual time.
    
    Update is used since initial commit so its unknown as to the reason why.
    
    If SetUpdateMode(true) is in use it won't happen so the flicker normally
    doesn't happen, but the equivalent we're using for the native gtk widgerty
    disconnects the model when frozen for performance, so setting cursor positions
    and other similar operations have to happen unfrozen. Not calling Update here
    would make things much easier.
    
    Change-Id: I4575e55802c54e5b849f076f2da79dd010fb27e8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90331
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx
index e1561ad12607..bc407216a696 100644
--- a/vcl/source/treelist/svimpbox.cxx
+++ b/vcl/source/treelist/svimpbox.cxx
@@ -1362,7 +1362,7 @@ void SvImpLBox::ShowVerSBar()
             m_pView->nFocusWidth = -1;
             AdjustScrollBars( m_aOutputSize );
             if( GetUpdateMode() )
-                m_aVerSBar->Update();
+                m_aVerSBar->Invalidate();
         }
     }
     else
@@ -1385,7 +1385,7 @@ void SvImpLBox::ShowVerSBar()
             m_pView->nFocusWidth = -1;
             AdjustScrollBars( m_aOutputSize );
             if( GetUpdateMode() )
-                m_aHorSBar->Update();
+                m_aHorSBar->Invalidate();
         }
         else
         {


More information about the Libreoffice-commits mailing list