[Libreoffice-commits] core.git: svl/qa svl/source

[Noel Grandin (via logerrit)]

 svl/qa/unit/svl.cxx              |    8 ++++----
 svl/source/crypto/cryptosign.cxx |    6 +++---
 svl/source/fsstor/fsstorage.cxx  |    4 ++--
 svl/source/items/style.cxx       |    2 +-
 svl/source/misc/gridprinter.cxx  |    2 +-
 svl/source/undo/undo.cxx         |    6 +++---
 svl/source/uno/pathservice.cxx   |    2 +-
 7 files changed, 15 insertions(+), 15 deletions(-)

New commits:
commit df3e1b7bbd126ed114015070bf68db30fbe9516e
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Fri Mar 13 10:01:24 2020 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Mar 13 19:21:01 2020 +0100

    Revert "loplugin:constfields in svl"
    
    This reverts commit 5181253946ca1877cc42050452aa6d733d6da3f1.
    
    Change-Id: I30e30aae45c33824c0df823a9fad710faa81ea3c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90453
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index 707754ac920f..fc541861f182 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -244,9 +244,9 @@ void Test::testNumberFormat()
     };
 
     struct {
-        NfIndexTableOffset const eStart;
-        NfIndexTableOffset const eEnd;
-        size_t const nSize;
+        NfIndexTableOffset eStart;
+        NfIndexTableOffset eEnd;
+        size_t nSize;
         const char** pCodes;
     } aTests[] = {
         { NF_NUMBER_START, NF_NUMBER_END, 6, pNumber },
@@ -1114,7 +1114,7 @@ void Test::testIsNumberFormat()
     static struct NumberFormatData
     {
         const char* pFormat;
-        bool const bIsNumber;
+        bool bIsNumber;
     } const aTests[] = {
         { "20.3", true },
         { "2", true },
diff --git a/svl/source/crypto/cryptosign.cxx b/svl/source/crypto/cryptosign.cxx
index 483a9ee31638..573c06ba5826 100644
--- a/svl/source/crypto/cryptosign.cxx
+++ b/svl/source/crypto/cryptosign.cxx
@@ -121,9 +121,9 @@ Extension  ::=  SEQUENCE  {
 */
 
 struct Extension {
-    SECItem const extnID;
-    SECItem const critical;
-    SECItem const extnValue;
+    SECItem  extnID;
+    SECItem  critical;
+    SECItem  extnValue;
 };
 
 /*
diff --git a/svl/source/fsstor/fsstorage.cxx b/svl/source/fsstor/fsstorage.cxx
index 0b566b2ac15d..344d4b01c751 100644
--- a/svl/source/fsstor/fsstorage.cxx
+++ b/svl/source/fsstor/fsstorage.cxx
@@ -60,9 +60,9 @@ using namespace ::com::sun::star;
 
 struct FSStorage_Impl
 {
-    OUString const m_aURL;
+    OUString  m_aURL;
     ::ucbhelper::Content m_aContent;
-    sal_Int32 const m_nMode;
+    sal_Int32 m_nMode;
     std::unique_ptr<::comphelper::OInterfaceContainerHelper2> m_pListenersContainer; // list of listeners
     uno::Reference< uno::XComponentContext > m_xContext;
 
diff --git a/svl/source/items/style.cxx b/svl/source/items/style.cxx
index 6d2095ad93b3..f8bbd6c25936 100644
--- a/svl/source/items/style.cxx
+++ b/svl/source/items/style.cxx
@@ -387,7 +387,7 @@ struct DoesStyleMatchStyleSheetPredicate final : public svl::StyleSheetPredicate
         return bMatches;
     }
 
-    SfxStyleSheetIterator * const mIterator;
+    SfxStyleSheetIterator *mIterator;
 };
 
 }
diff --git a/svl/source/misc/gridprinter.cxx b/svl/source/misc/gridprinter.cxx
index b40dd049c8ef..ae910e4f0cf7 100644
--- a/svl/source/misc/gridprinter.cxx
+++ b/svl/source/misc/gridprinter.cxx
@@ -55,7 +55,7 @@ typedef mdds::multi_type_matrix<matrix_trait> MatrixImplType;
 struct GridPrinter::Impl
 {
     MatrixImplType maMatrix;
-    bool const mbPrint;
+    bool mbPrint;
 
     Impl( size_t nRows, size_t nCols, bool bPrint ) :
         maMatrix(nRows, nCols, OUString()), mbPrint(bPrint) {}
diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx
index 868982813f98..a08e451e471d 100644
--- a/svl/source/undo/undo.cxx
+++ b/svl/source/undo/undo.cxx
@@ -1258,11 +1258,11 @@ void SfxUndoManager::EmptyActionsChanged()
 
 struct SfxListUndoAction::Impl
 {
-    sal_uInt16 const mnId;
-    ViewShellId const mnViewShellId;
+    sal_uInt16 mnId;
+    ViewShellId mnViewShellId;
 
     OUString maComment;
-    OUString const maRepeatComment;
+    OUString maRepeatComment;
 
     Impl( sal_uInt16 nId, ViewShellId nViewShellId, const OUString& rComment, const OUString& rRepeatComment ) :
         mnId(nId), mnViewShellId(nViewShellId), maComment(rComment), maRepeatComment(rRepeatComment) {}
diff --git a/svl/source/uno/pathservice.cxx b/svl/source/uno/pathservice.cxx
index c0b951f15046..b1d109894bf3 100644
--- a/svl/source/uno/pathservice.cxx
+++ b/svl/source/uno/pathservice.cxx
@@ -34,7 +34,7 @@ namespace {
 
 class PathService : public ::cppu::WeakImplHelper< css::frame::XConfigManager, css::lang::XServiceInfo >
 {
-    SvtPathOptions const m_aOptions;
+    SvtPathOptions m_aOptions;
 
 public:
     PathService()