[Libreoffice-commits] core.git: connectivity/source

[Julien Nabet (via logerrit)]

 connectivity/source/drivers/firebird/DatabaseMetaData.cxx |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 65374780cb9df1ca7007b49a759fb3634f0c168f
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sun Mar 15 18:01:37 2020 +0100
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sun Mar 15 20:07:10 2020 +0100

    Firebird: IndexType is OTHER not CLUSTERED
    
    Wikipedia indicates:
    'Firebird makes all indices of the database behave like well-tuned "clustered indexes" used by other architectures.'
    but it's not "CLUSTERED", neither "STATISTIC" nor "HASHED" (the other specific types from offapi/com/sun/star/sdbc/IndexType.idl)
    According to https://www.ibphoenix.com/resources/documents/design/doc_18,
    it seems another type => OTHER
    
    Change-Id: I3eefe9bd025e1cfeaefb75091f7ed03e8642dfea
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90537
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
index ec685086bb52..19c6f5755df9 100644
--- a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
+++ b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
@@ -1654,9 +1654,12 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getIndexInfo(
     aCurrentRow[1] = new ORowSetValueDecorator(); // Catalog - can be null
     aCurrentRow[2] = new ORowSetValueDecorator(); // Schema - can be null
     aCurrentRow[5] = new ORowSetValueDecorator(); // Index Catalog -- can be null
-    // According to wikipedia firebird uses clustered indices.
-    // The documentation does not specifically seem to specify this.
-    aCurrentRow[7] = new ORowSetValueDecorator(IndexType::CLUSTERED); // 7. INDEX TYPE
+    // Wikipedia indicates:
+    // 'Firebird makes all indices of the database behave like well-tuned "clustered indexes" used by other architectures.'
+    // but it's not "CLUSTERED", neither "STATISTIC" nor "HASHED" (the other specific types from offapi/com/sun/star/sdbc/IndexType.idl)
+    // According to https://www.ibphoenix.com/resources/documents/design/doc_18,
+    // it seems another type => OTHER
+    aCurrentRow[7] = new ORowSetValueDecorator(IndexType::OTHER); // 7. INDEX TYPE
     aCurrentRow[13] = new ORowSetValueDecorator(); // Filter Condition -- can be null
 
     while(xRs->next())